[MD settings] icons for clickable rows

chrome/browser/resources/settings/settings_shared_css.html

 <link rel="import" href="chrome://resources/cr_elements/shared_style_css.html">
 <link rel="import" href="/settings_vars_css.html">
 
 <!-- Common styles for Material Design settings. -->
 <dom-module id="settings-shared">
   <template>
     <style include="cr-shared-style">
+      button[is="paper-icon-button-light"] {
+        --paper-ripple: {

[tommycli, 2016/09/23 19:29:57]

Maybe a comment that these dimenisons are to center over the background image?

[dschuyler, 2016/09/27 00:43:09]

Done.

+          height: 36px;
+          left: -8px;
+          top: -8px;
+          width: 36px;
+        };
+        -webkit-margin-start: 16px;
+        background-size: cover;
+        flex-shrink: 0;
+        height: 20px;
+        margin: 0;
+        width: 20px;
+      }
+
+      [actionable] button[is="paper-icon-button-light"].icon-arrow-right {
+        background-image: url("data:image/svg+xml;charset=UTF-8,%3Csvg%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%20width%3D%2224px%22%20height%3D%2224px%22%20viewBox%3D%220%200%2024%2024%22%20fill%3D%22%23757575%22%3E%3Cg%3E%3Cpath%20d%3D%22M7%2014l5-5%205%205z%22%3E%3C%2Fpath%3E%3C%2Fg%3E%3C%2Fsvg%3E");
+        transform: rotate(90deg);
+      }
+
+      [actionable] button[is="paper-icon-button-light"].icon-external {
+        background-image: url("data:image/svg+xml;charset=UTF-8,%3Csvg%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%20width%3D%2224px%22%20height%3D%2224px%22%20viewBox%3D%220%200%2024%2024%22%20fill%3D%22%23bdbdbd%22%3E%3Cg%3E%3Cpath%20d%3D%22M19%2019H5V5h7V3H5c-1.11%200-2%20.9-2%202v14c0%201.1.89%202%202%202h14c1.1%200%202-.9%202-2v-7h-2v7zM14%203v2h3.59l-9.83%209.83%201.41%201.41L19%206.41V10h2V3h-7z%22%3E%3C%2Fpath%3E%3C%2Fg%3E%3C%2Fsvg%3E");
+      }
+
       /* Use <h2> as the "sub-header" mentioned in the UX design docs. */
       h2 {
         align-items: center;
         align-self: flex-start;
         color: var(--paper-grey-600);
         display: flex;
         font-size: inherit;
         font-weight: 500;
         margin: 0;
         padding-top: 24px;
         padding-bottom: 12px;
       }
 
       iron-icon[icon='cr:check'],
       iron-icon[icon='settings:done'] {
        --iron-icon-fill-color: var(--google-green-500);
       }
 
       paper-button {
         margin: 0;
       }
 
       paper-button[toggles][active] {
         background-color: var(--paper-grey-300);
       }
 
       paper-toggle-button {
         @apply(--settings-actionable);
-        height: 20px;
+        height: var(--settings-row-min-height);
         width: 31px;
       }
 
       paper-dropdown-menu-light {
         --iron-icon-fill-color: var(--paper-grey-600);
         --paper-font-subhead: {
           font-size: inherit;
         };
         --paper-dropdown-menu-input: {
           border-bottom-color: var(--paper-grey-300);
@@ skipping 244 matching lines @@
         justify-content: center;
       }
 
       /* The lower line of text in a .settings-box.two-line. */
       .settings-box .secondary {
         @apply(--settings-secondary);
       }
 
       /* The middle part (horizontally) of a row. */
       .settings-box .middle {
-        -webkit-margin-start: 16px;
+        -webkit-padding-start: 16px;
         align-items: center;
         flex: auto;
       }
 
+      .settings-box .middle.two-line {
+        display: flex;
+        min-height: var(--settings-row-two-line-min-height);
+      }
+
       /* The start (left in LTR) part (horizontally) of a row. */
       .settings-box .start {
         align-items: center;
         flex: auto;
       }
 
       /* The secondary-action wraps a clickable sub-area of a .settings-box.
        * An example is the |sign out| button on the People settings.
        * Here is an example with and without a secondary action box:
        *
        *  +-------------------------------------------------------+
        *  | Main action area .settings-box    | .secondary-action |
        *  +-------------------------------------------------------+
        *  | Another setting-box without a secondary-action        |
        *  +-------------------------------------------------------+ */
       .settings-box .secondary-action {
         -webkit-border-start: var(--settings-separator-line);
+        -webkit-margin-start: 20px;

[tommycli, 2016/09/23 19:29:57]

Why is this required?

[dschuyler, 2016/09/27 00:43:09]

I know it looks strange because normally we use 
a margin x-or padding. In this case the vertical
line is made by the border of the div that wraps
the contents in the secondary-action. The margin 
is on one side of the border and the padding is 
on the other side.

         -webkit-padding-start: 20px;
+        align-items: center;
+        display: flex;
         flex-shrink: 0;
+        height: 33px;

[tommycli, 2016/09/23 19:29:57]

This seems odd. Why is this height required?

[dschuyler, 2016/09/27 00:43:09]

It previously didn't have a height and the 
height was implicit from the contents of 
secondary-action. That height is 33px. That
just happened to work out until I put something
other than a button in the secondary-action.
So now it's being set explicitly so that it's
consistent.

       }
 
       .settings-box paper-item iron-icon {
         /* Same padding as paper-icon-button. */
         padding: 8px;
       }
 
       /* Helper for a list frame to automatically avoid the separator line. */
       .vertical-list > *:not(:first-of-type) {
         border-top: var(--settings-separator-line);
@@ skipping 49 matching lines @@
       /* Turns the arrow direction downwards, when the bubble is placed above
        * the anchor element */
       .search-bubble-innards.above::after {
         -webkit-transform: rotate(-135deg);
         bottom: -5px;
         top: auto;
       }
     </style>
   </template>
 </dom-module>