Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Side by Side Diff: chrome/browser/resources/settings/default_browser_page/default_browser_page.html

Issue 2356653002: [MD settings] icons for clickable rows (Closed)
Patch Set: significant update Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html"> 2 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button-light.html">
3 <link rel="import" href="/default_browser_page/default_browser_browser_proxy.htm l"> 4 <link rel="import" href="/default_browser_page/default_browser_browser_proxy.htm l">
4 <link rel="import" href="/icons.html"> 5 <link rel="import" href="/icons.html">
5 <link rel="import" href="/settings_shared_css.html"> 6 <link rel="import" href="/settings_shared_css.html">
6 7
7 <dom-module id="settings-default-browser-page"> 8 <dom-module id="settings-default-browser-page">
8 <template> 9 <template>
9 <style include="settings-shared"> 10 <style include="settings-shared">
10 .solo-secondary { 11 .solo-secondary {
11 @apply(--settings-secondary); 12 @apply(--settings-secondary);
12 margin: 0; 13 margin: 0;
13 } 14 }
14 </style> 15 </style>
15 <template is="dom-if" if="[[maySetDefaultBrowser_]]"> 16 <template is="dom-if" if="[[maySetDefaultBrowser_]]">
16 <div class="settings-box first two-line" on-tap="onSetDefaultBrowserTap_" 17 <div class="settings-box first two-line" on-tap="onSetDefaultBrowserTap_"
17 actionable> 18 actionable>
18 <div> 19 <div class="start">
19 <div id="canBeDefaultBrowser">$i18n{defaultBrowser}</div> 20 <div id="canBeDefaultBrowser">$i18n{defaultBrowser}</div>
20 <div class="secondary">$i18n{defaultBrowserMakeDefault}</div> 21 <div class="secondary">$i18n{defaultBrowserMakeDefault}</div>
21 </div> 22 </div>
23 <button class="icon-arrow-right" is="paper-icon-button-light">
24 </button>
22 </div> 25 </div>
23 </template> 26 </template>
24 <template is="dom-if" if="[[!maySetDefaultBrowser_]]"> 27 <template is="dom-if" if="[[!maySetDefaultBrowser_]]">
25 <div class="settings-box first"> 28 <div class="settings-box first">
26 <div class="solo-secondary" hidden$="[[!isDefault_]]" id="isDefault"> 29 <div class="solo-secondary start" hidden$="[[!isDefault_]]"
30 id="isDefault">
27 $i18n{defaultBrowserDefault} 31 $i18n{defaultBrowserDefault}
28 </div> 32 </div>
29 <div class="solo-secondary" hidden$="[[!isSecondaryInstall_]]" 33 <div class="solo-secondary start" hidden$="[[!isSecondaryInstall_]]"
30 id="isSecondaryInstall"> 34 id="isSecondaryInstall">
31 $i18n{defaultBrowserSecondary} 35 $i18n{defaultBrowserSecondary}
32 </div> 36 </div>
33 <div class="solo-secondary" hidden$="[[!isUnknownError_]]" 37 <div class="solo-secondary start" hidden$="[[!isUnknownError_]]"
34 id="isUnknownError"> 38 id="isUnknownError">
35 $i18n{defaultBrowserError} 39 $i18n{defaultBrowserError}
36 </div> 40 </div>
41 <button class="icon-arrow-right" is="paper-icon-button-light">
42 </button>
tommycli 2016/09/23 19:29:57 nit: We really should have made one div class and
dschuyler 2016/09/27 00:43:09 Acknowledged.
37 </div> 43 </div>
38 </template> 44 </template>
39 </template> 45 </template>
40 <script src="default_browser_page.js"></script> 46 <script src="default_browser_page.js"></script>
41 </dom-module> 47 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698