Fix cr-shared-menu focus issues.

Fix cr-shared-menu focus issues.

cr-shared-menu uses special logic to keep focus within the expanded menu. This
should not target non-focuscable items. There is also a bug where this logic
wraps to the fist element instead of moving backwards when Shift+Tab is pressed
on the last element.

BUG=648471
R=tsergeant@chromium.org
TEST=CrElementsSharedMenuTest.All
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a0940bc1fbbe088a791c61b7f52e0a63930f6c4f
Cr-Commit-Position: refs/heads/master@{#419657}

[michaelpg, 2016-09-20 01:17:23]

Description was changed from

==========
Fix cr-shared-menu focus issues.

cr-shared-menu uses special logic to keep focus within the expanded menu. This
should not target non-focuscable items. There is also a bug where this logic
wraps to the fist element instead of moving backwards when Shift+Tab is pressed
on the last element.

BUG=648471
R=tsergeant@chromium.org
TEST=CrElementsSharedMenuTest.All
==========

to

==========
Fix cr-shared-menu focus issues.

cr-shared-menu uses special logic to keep focus within the expanded menu. This
should not target non-focuscable items. There is also a bug where this logic
wraps to the fist element instead of moving backwards when Shift+Tab is pressed
on the last element.

BUG=648471
R=tsergeant@chromium.org
TEST=CrElementsSharedMenuTest.All
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-09-20 01:18:57]

PTAL, sorry rietveld sucks at diffing

[tsergeant, 2016-09-20 01:46:32]

lgtm, thanks

[michaelpg, 2016-09-20 01:54:55]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2016-09-20 01:55:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-09-20 02:07:16]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-09-20 02:07:17]

does this require a vulcanize run?

[tsergeant, 2016-09-20 02:27:22]

On 2016/09/20 02:07:17, Dan Beam wrote:
> does this require a vulcanize run?

theoretically, yes. In practice, neither of these issues affect MD History, so
I'm happy for the changes to roll through later.

[commit-bot: I haz the power, 2016-09-20 02:43:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-20 02:45:05]

Description was changed from

==========
Fix cr-shared-menu focus issues.

cr-shared-menu uses special logic to keep focus within the expanded menu. This
should not target non-focuscable items. There is also a bug where this logic
wraps to the fist element instead of moving backwards when Shift+Tab is pressed
on the last element.

BUG=648471
R=tsergeant@chromium.org
TEST=CrElementsSharedMenuTest.All
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix cr-shared-menu focus issues.

cr-shared-menu uses special logic to keep focus within the expanded menu. This
should not target non-focuscable items. There is also a bug where this logic
wraps to the fist element instead of moving backwards when Shift+Tab is pressed
on the last element.

BUG=648471
R=tsergeant@chromium.org
TEST=CrElementsSharedMenuTest.All
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a0940bc1fbbe088a791c61b7f52e0a63930f6c4f
Cr-Commit-Position: refs/heads/master@{#419657}
==========

[commit-bot: I haz the power, 2016-09-20 02:45:06]

Patchset 1 (id:??) landed as
https://crrev.com/a0940bc1fbbe088a791c61b7f52e0a63930f6c4f
Cr-Commit-Position: refs/heads/master@{#419657}