Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2356643002: Change offline pages icon from offline_bolt to offline_pin (Closed)

Created:
4 years, 3 months ago by qinmin
Modified:
4 years, 3 months ago
Reviewers:
gone
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change offline pages icon from offline_bolt to offline_pin Change the offline page icon first For download completion notification, still pending clarification BUG=648221 Committed: https://crrev.com/2a1ab08216d58fe00125ee6408f1850ada6e3d23 Cr-Commit-Position: refs/heads/master@{#419613}

Patch Set 1 #

Patch Set 2 : optimize resources #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
D chrome/android/java/res/drawable-hdpi/offline_bolt.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-hdpi/offline_pin.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/offline_bolt.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/offline_pin.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/offline_bolt.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/offline_pin.png View 1 Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/offline_bolt.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/offline_pin.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/offline_bolt.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/offline_pin.png View 1 Binary file 0 comments Download
M chrome/android/java/res/layout/most_visited_item.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/layout/website_settings.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
qinmin
PTAL
4 years, 3 months ago (2016-09-19 23:31:23 UTC) #2
gone
lgtm
4 years, 3 months ago (2016-09-19 23:40:16 UTC) #3
gone
Make sure to run ./tools/resources/optimize-png-files.sh on these.
4 years, 3 months ago (2016-09-19 23:40:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356643002/20001
4 years, 3 months ago (2016-09-20 00:19:17 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-20 00:50:25 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 00:52:27 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2a1ab08216d58fe00125ee6408f1850ada6e3d23
Cr-Commit-Position: refs/heads/master@{#419613}

Powered by Google App Engine
This is Rietveld 408576698