Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2356603003: Change protected to private in CPDF_CID2UnicodeMap and CPDF_ToUnicodeMap (Closed)

Created:
4 years, 3 months ago by npm
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, dsinclair, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Change protected to private in CPDF_CID2UnicodeMap and CPDF_ToUnicodeMap Committed: https://pdfium.googlesource.com/pdfium/+/60e903c33480ab0baf0faff9c848bc8992180454

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M core/fpdfapi/fpdf_font/font_int.h View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
npm
PTAL
4 years, 3 months ago (2016-09-20 20:48:19 UTC) #4
dsinclair
lgtm
4 years, 3 months ago (2016-09-20 20:52:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356603003/1
4 years, 3 months ago (2016-09-20 21:03:57 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 21:04:14 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/60e903c33480ab0baf0faff9c848bc899218...

Powered by Google App Engine
This is Rietveld 408576698