Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Unified Diff: chrome/test/chromedriver/server/http_handler_unittest.cc

Issue 23566018: [chromedriver] Remove Logger and just use base LOG. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/server/http_handler.cc ('k') | chrome/test/chromedriver/session_commands.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/server/http_handler_unittest.cc
diff --git a/chrome/test/chromedriver/server/http_handler_unittest.cc b/chrome/test/chromedriver/server/http_handler_unittest.cc
index a9f4e2d4a74d6da84b8070d27e1de38916fe1f2e..4f3f21222d134ef14c7f2acfadf3aa48316a38af 100644
--- a/chrome/test/chromedriver/server/http_handler_unittest.cc
+++ b/chrome/test/chromedriver/server/http_handler_unittest.cc
@@ -37,8 +37,7 @@ void OnResponse(net::HttpServerResponseInfo* response_to_set,
} // namespace
TEST(HttpHandlerTest, HandleOutsideOfBaseUrl) {
- Logger log;
- HttpHandler handler(&log, "base/url/");
+ HttpHandler handler("base/url/");
net::HttpServerRequestInfo request;
request.method = "get";
request.path = "base/path";
@@ -49,8 +48,7 @@ TEST(HttpHandlerTest, HandleOutsideOfBaseUrl) {
}
TEST(HttpHandlerTest, HandleUnknownCommand) {
- Logger log;
- HttpHandler handler(&log, "/");
+ HttpHandler handler("/");
net::HttpServerRequestInfo request;
request.method = "get";
request.path = "/path";
@@ -60,8 +58,7 @@ TEST(HttpHandlerTest, HandleUnknownCommand) {
}
TEST(HttpHandlerTest, HandleNewSession) {
- Logger log;
- HttpHandler handler(&log, "/base/");
+ HttpHandler handler("/base/");
handler.command_map_.reset(new HttpHandler::CommandMap());
handler.command_map_->push_back(
CommandMapping(kPost, internal::kNewSessionPathPattern,
@@ -78,8 +75,7 @@ TEST(HttpHandlerTest, HandleNewSession) {
}
TEST(HttpHandlerTest, HandleInvalidPost) {
- Logger log;
- HttpHandler handler(&log, "/");
+ HttpHandler handler("/");
handler.command_map_->push_back(
CommandMapping(kPost, "path", base::Bind(&DummyCommand, Status(kOk))));
net::HttpServerRequestInfo request;
@@ -92,8 +88,7 @@ TEST(HttpHandlerTest, HandleInvalidPost) {
}
TEST(HttpHandlerTest, HandleUnimplementedCommand) {
- Logger log;
- HttpHandler handler(&log, "/");
+ HttpHandler handler("/");
handler.command_map_->push_back(
CommandMapping(kPost, "path",
base::Bind(&DummyCommand, Status(kUnknownCommand))));
@@ -106,8 +101,7 @@ TEST(HttpHandlerTest, HandleUnimplementedCommand) {
}
TEST(HttpHandlerTest, HandleCommand) {
- Logger log;
- HttpHandler handler(&log, "/");
+ HttpHandler handler("/");
handler.command_map_->push_back(
CommandMapping(kPost, "path", base::Bind(&DummyCommand, Status(kOk))));
net::HttpServerRequestInfo request;
« no previous file with comments | « chrome/test/chromedriver/server/http_handler.cc ('k') | chrome/test/chromedriver/session_commands.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698