Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: chrome/test/chromedriver/chrome/chrome_impl.cc

Issue 23566018: [chromedriver] Remove Logger and just use base LOG. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_impl.h ('k') | chrome/test/chromedriver/chrome/console_logger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/chrome_impl.cc
diff --git a/chrome/test/chromedriver/chrome/chrome_impl.cc b/chrome/test/chromedriver/chrome/chrome_impl.cc
index e4c4971e95cccb75940649602c5511e5951a90af..a7b359528aa494028e70496baa3e9c7ab34c4fe0 100644
--- a/chrome/test/chromedriver/chrome/chrome_impl.cc
+++ b/chrome/test/chromedriver/chrome/chrome_impl.cc
@@ -7,7 +7,6 @@
#include "chrome/test/chromedriver/chrome/devtools_client.h"
#include "chrome/test/chromedriver/chrome/devtools_event_listener.h"
#include "chrome/test/chromedriver/chrome/devtools_http_client.h"
-#include "chrome/test/chromedriver/chrome/log.h"
#include "chrome/test/chromedriver/chrome/status.h"
#include "chrome/test/chromedriver/chrome/web_view_impl.h"
@@ -61,7 +60,7 @@ Status ChromeImpl::GetWebViewIds(std::list<std::string>* web_view_ids) {
// OnConnected will fire when DevToolsClient connects later.
}
web_views_.push_back(make_linked_ptr(new WebViewImpl(
- view.id, GetBuildNo(), client.Pass(), log_)));
+ view.id, GetBuildNo(), client.Pass())));
}
}
@@ -109,9 +108,7 @@ Status ChromeImpl::GetAutomationExtension(AutomationExtension** extension) {
ChromeImpl::ChromeImpl(
scoped_ptr<DevToolsHttpClient> client,
- ScopedVector<DevToolsEventListener>& devtools_event_listeners,
- Log* log)
- : devtools_http_client_(client.Pass()),
- log_(log) {
+ ScopedVector<DevToolsEventListener>& devtools_event_listeners)
+ : devtools_http_client_(client.Pass()) {
devtools_event_listeners_.swap(devtools_event_listeners);
}
« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_impl.h ('k') | chrome/test/chromedriver/chrome/console_logger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698