Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

Issue 23566018: [chromedriver] Remove Logger and just use base LOG. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
diff --git a/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc b/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
index 5abf7694fafbbae6e57dc578f92a316c737cf9cd..f15b8959bce09be8c1cfa56382c0d64d0eb480ed 100644
--- a/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
+++ b/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
@@ -63,13 +63,11 @@ bool KillProcess(base::ProcessHandle process_id) {
ChromeDesktopImpl::ChromeDesktopImpl(
scoped_ptr<DevToolsHttpClient> client,
ScopedVector<DevToolsEventListener>& devtools_event_listeners,
- Log* log,
base::ProcessHandle process,
base::ScopedTempDir* user_data_dir,
base::ScopedTempDir* extension_dir)
: ChromeImpl(client.Pass(),
- devtools_event_listeners,
- log),
+ devtools_event_listeners),
process_(process),
quit_(false) {
if (user_data_dir->IsValid())
@@ -113,7 +111,7 @@ Status ChromeDesktopImpl::WaitForPageToLoad(const std::string& url,
return Status(kUnknownError, "page could not be found: " + url);
scoped_ptr<WebView> web_view_tmp(new WebViewImpl(
- id, GetBuildNo(), devtools_http_client_->CreateClient(id), log_));
+ id, GetBuildNo(), devtools_http_client_->CreateClient(id)));
Status status = web_view_tmp->ConnectIfNecessary();
if (status.IsError())
return status;
« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_desktop_impl.h ('k') | chrome/test/chromedriver/chrome/chrome_existing_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698