Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5218)

Unified Diff: chrome/test/chromedriver/chrome/adb_impl.cc

Issue 23566018: [chromedriver] Remove Logger and just use base LOG. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/chrome/adb_impl.h ('k') | chrome/test/chromedriver/chrome/chrome_android_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/adb_impl.cc
diff --git a/chrome/test/chromedriver/chrome/adb_impl.cc b/chrome/test/chromedriver/chrome/adb_impl.cc
index 66c81b3daae3c978d986e0b41c90c91ad3dc59a0..ce1271a21b7f962b3a4d5a0a059d92bac2ffd586 100644
--- a/chrome/test/chromedriver/chrome/adb_impl.cc
+++ b/chrome/test/chromedriver/chrome/adb_impl.cc
@@ -17,7 +17,6 @@
#include "base/strings/stringprintf.h"
#include "base/synchronization/waitable_event.h"
#include "base/time/time.h"
-#include "chrome/test/chromedriver/chrome/log.h"
#include "chrome/test/chromedriver/chrome/status.h"
#include "chrome/test/chromedriver/net/adb_client_socket.h"
@@ -74,8 +73,8 @@ void ExecuteCommandOnIOThread(
AdbImpl::AdbImpl(
const scoped_refptr<base::SingleThreadTaskRunner>& io_task_runner,
- Log* log, int port)
- : io_task_runner_(io_task_runner), log_(log), port_(port) {
+ int port)
+ : io_task_runner_(io_task_runner), port_(port) {
CHECK(io_task_runner_.get());
}
@@ -219,14 +218,15 @@ Status AdbImpl::GetPidByName(const std::string& device_serial,
Status AdbImpl::ExecuteCommand(
const std::string& command, std::string* response) {
scoped_refptr<ResponseBuffer> response_buffer = new ResponseBuffer;
- log_->AddEntry(Log::kDebug, "Sending adb command: " + command);
+ VLOG(1) << "Sending adb command: " << command;
io_task_runner_->PostTask(
FROM_HERE,
base::Bind(&ExecuteCommandOnIOThread, command, response_buffer, port_));
Status status = response_buffer->GetResponse(
response, base::TimeDelta::FromSeconds(30));
- if (status.IsOk())
- log_->AddEntry(Log::kDebug, "Received adb response: " + *response);
+ if (status.IsOk()) {
+ VLOG(1) << "Received adb response: " << *response;
+ }
return status;
}
« no previous file with comments | « chrome/test/chromedriver/chrome/adb_impl.h ('k') | chrome/test/chromedriver/chrome/chrome_android_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698