Issue 23566006: Get rid of OS(SOLARIS) and OS(HURD).

Issue 23566006: Get rid of OS(SOLARIS) and OS(HURD). (Closed)

Created:
7 years, 3 months ago by Chris Evans

Modified:
7 years, 3 months ago

Reviewers:
Nils Barth (inactive), abarth-chromium

CC:
blink-reviews, Nils Barth (inactive), kojih, loislo+blink_chromium.org, jsbell+bindings_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, jeez, do-not-use

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Description

Get rid of OS(SOLARIS) and OS(HURD). R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156830

Patch Set 1 #

Total comments: 2

Patch Set 2 : git cl try #

Created: 7 years, 3 months ago

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -45 lines)
M	Source/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp	View	1 chunk	+0 lines, -2 lines	0 comments
M	Source/config.h	View	4 chunks	+1 line, -13 lines	0 comments
M	Source/core/platform/network/ResourceResponse.h	View	1 chunk	+0 lines, -4 lines	0 comments
M	Source/wtf/MathExtras.h	View	2 chunks	+0 lines, -22 lines	0 comments
M	Source/wtf/NumberOfCores.cpp	View	2 chunks	+2 lines, -2 lines	0 comments
M	Source/wtf/ThreadIdentifierDataPthreads.cpp	View	1 chunk	+2 lines, -2 lines	0 comments

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nils Barth (inactive)

https://codereview.chromium.org/23566006/diff/1/Source/wtf/ThreadIdentifierDataPthreads.cpp File Source/wtf/ThreadIdentifierDataPthreads.cpp (right): https://codereview.chromium.org/23566006/diff/1/Source/wtf/ThreadIdentifierDataPthreads.cpp#newcode41 Source/wtf/ThreadIdentifierDataPthreads.cpp:41: // PTHREAD_KEYS_MAX is not defined in bionic nor in ...

7 years, 3 months ago (2013-08-28 04:32:33 UTC) #2

abarth-chromium

lgtm https://codereview.chromium.org/23566006/diff/1/Source/wtf/ThreadIdentifierDataPthreads.cpp File Source/wtf/ThreadIdentifierDataPthreads.cpp (right): https://codereview.chromium.org/23566006/diff/1/Source/wtf/ThreadIdentifierDataPthreads.cpp#newcode41 Source/wtf/ThreadIdentifierDataPthreads.cpp:41: // PTHREAD_KEYS_MAX is not defined in bionic nor ...

7 years, 3 months ago (2013-08-28 06:32:31 UTC) #3

Chris Evans

On 2013/08/28 06:32:31, abarth wrote: > lgtm > > https://codereview.chromium.org/23566006/diff/1/Source/wtf/ThreadIdentifierDataPthreads.cpp > File Source/wtf/ThreadIdentifierDataPthreads.cpp (right): > ...

7 years, 3 months ago (2013-08-28 07:35:52 UTC) #4

Chris Evans

7 years, 3 months ago (2013-08-28 08:32:14 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r156830 (presubmit successful).

Expand Messages | Collapse Messages