Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2356593002:
DevTools: Add UC Browser to preset list of user agent overrides (Closed)
|
Created:
4 years, 3 months ago by luoe Modified:
4 years, 3 months ago Reviewers:
lushnikov CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: Add UC Browser to preset list of user agent overrides
Adds a new section to the user agent override preset list.
Sources for user agents:
https://www.whatismybrowser.com/developers/tools/user-agent-parser/browse/browser-name/uc-browser-user-agents
http://www.webapps-online.com/online-tools/user-agent-strings/dv/browser212364/uc-browser
BUG=646360
Committed: https://crrev.com/a6027ccd55c6222e19a2d74dd9878fcb35248e88
Cr-Commit-Position: refs/heads/master@{#419913}
Patch Set 1 #Patch Set 2 : Add UC browser #
Total comments: 2
Patch Set 3 : fix typo #Messages
Total messages: 22 (14 generated)
Description was changed from ========== Add UC browser BUG=646360 ========== to ========== DevTools: Add UC Browser to preset list of user agent overrides Adds a new section to the user agent override preset list. Sources for user agents: https://www.whatismybrowser.com/developers/tools/user-agent-parser/browse/bro... http://www.webapps-online.com/online-tools/user-agent-strings/dv/browser21236... BUG=646360 ==========
Description was changed from ========== DevTools: Add UC Browser to preset list of user agent overrides Adds a new section to the user agent override preset list. Sources for user agents: https://www.whatismybrowser.com/developers/tools/user-agent-parser/browse/bro... http://www.webapps-online.com/online-tools/user-agent-strings/dv/browser21236... BUG=646360 ========== to ========== DevTools: Add UC Browser to preset list of user agent overrides Adds a new section to the user agent override preset list. BUG=646360 ==========
Description was changed from ========== DevTools: Add UC Browser to preset list of user agent overrides Adds a new section to the user agent override preset list. BUG=646360 ========== to ========== DevTools: Add UC Browser to preset list of user agent overrides Adds a new section to the user agent override preset list. Sources for user agents: https://www.whatismybrowser.com/developers/tools/user-agent-parser/browse/bro... http://www.webapps-online.com/online-tools/user-agent-strings/dv/browser21236... BUG=646360 ==========
luoe@chromium.org changed reviewers: + lushnikov@chromium.org
lgtm https://codereview.chromium.org/2356593002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js (right): https://codereview.chromium.org/2356593002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js:249: {title: "UC Browser \u2014 Android MobileZ", value: "Mozilla/5.0 (Linux; U; Android 4.4.4; en-US; XT1022 Build/KXC21.5-40) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 UCBrowser/10.7.0.636 U3/0.8.0 Mobile Safari/534.30"}, android mobileZ?!
https://codereview.chromium.org/2356593002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js (right): https://codereview.chromium.org/2356593002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js:249: {title: "UC Browser \u2014 Android MobileZ", value: "Mozilla/5.0 (Linux; U; Android 4.4.4; en-US; XT1022 Build/KXC21.5-40) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 UCBrowser/10.7.0.636 U3/0.8.0 Mobile Safari/534.30"}, On 2016/09/20 18:13:15, lushnikov wrote: > android mobileZ?! Done.
The CQ bit was checked by luoe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lushnikov@chromium.org Link to the patchset: https://codereview.chromium.org/2356593002/#ps40001 (title: "fix typo")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by luoe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by luoe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== DevTools: Add UC Browser to preset list of user agent overrides Adds a new section to the user agent override preset list. Sources for user agents: https://www.whatismybrowser.com/developers/tools/user-agent-parser/browse/bro... http://www.webapps-online.com/online-tools/user-agent-strings/dv/browser21236... BUG=646360 ========== to ========== DevTools: Add UC Browser to preset list of user agent overrides Adds a new section to the user agent override preset list. Sources for user agents: https://www.whatismybrowser.com/developers/tools/user-agent-parser/browse/bro... http://www.webapps-online.com/online-tools/user-agent-strings/dv/browser21236... BUG=646360 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== DevTools: Add UC Browser to preset list of user agent overrides Adds a new section to the user agent override preset list. Sources for user agents: https://www.whatismybrowser.com/developers/tools/user-agent-parser/browse/bro... http://www.webapps-online.com/online-tools/user-agent-strings/dv/browser21236... BUG=646360 ========== to ========== DevTools: Add UC Browser to preset list of user agent overrides Adds a new section to the user agent override preset list. Sources for user agents: https://www.whatismybrowser.com/developers/tools/user-agent-parser/browse/bro... http://www.webapps-online.com/online-tools/user-agent-strings/dv/browser21236... BUG=646360 Committed: https://crrev.com/a6027ccd55c6222e19a2d74dd9878fcb35248e88 Cr-Commit-Position: refs/heads/master@{#419913} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/a6027ccd55c6222e19a2d74dd9878fcb35248e88 Cr-Commit-Position: refs/heads/master@{#419913} |
