Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2356583003: PPC/s390: [Interpreter] Adds stackcheck in InterpreterPushArgsAndCall/Construct builtins. (Closed)

Created:
4 years, 3 months ago by yangtian.zi
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [Interpreter] Adds stackcheck in InterpreterPushArgsAndCall/Construct builtins. Port 7f3d15aad423aabf2f9116a929c8fd750615610a Original commit message: In ignition, arguments to function calls and function constructors are pushed onto the stack before calling the function. It is required to check that stack does not overflow when pushing the arguments. R=mythria@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= Committed: https://crrev.com/3b4cc88e9cec2fcbee0ca99514d876a6b30874b3 Cr-Commit-Position: refs/heads/master@{#39561}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Applied suggested changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -59 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 10 chunks +50 lines, -30 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 1 10 chunks +50 lines, -29 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
john.yan
lgtm with comments. https://codereview.chromium.org/2356583003/diff/1/src/builtins/s390/builtins-s390.cc File src/builtins/s390/builtins-s390.cc (right): https://codereview.chromium.org/2356583003/diff/1/src/builtins/s390/builtins-s390.cc#newcode2916 src/builtins/s390/builtins-s390.cc:2916: Generate_StackOverflowCheck(masm, r4, r8, &stack_overflow); r8 should ...
4 years, 3 months ago (2016-09-20 16:55:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356583003/20001
4 years, 3 months ago (2016-09-20 17:05:16 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-20 17:52:39 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 17:53:07 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3b4cc88e9cec2fcbee0ca99514d876a6b30874b3
Cr-Commit-Position: refs/heads/master@{#39561}

Powered by Google App Engine
This is Rietveld 408576698