Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: Source/modules/webaudio/AudioBuffer.h

Issue 235653002: WebAudio createBuffer should throw error with 0 channels. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 26 matching lines...) Expand all
37 #include "wtf/Vector.h" 37 #include "wtf/Vector.h"
38 38
39 namespace WebCore { 39 namespace WebCore {
40 40
41 class AudioBus; 41 class AudioBus;
42 class ExceptionState; 42 class ExceptionState;
43 43
44 class AudioBuffer : public ScriptWrappable, public RefCounted<AudioBuffer> { 44 class AudioBuffer : public ScriptWrappable, public RefCounted<AudioBuffer> {
45 public: 45 public:
46 static PassRefPtr<AudioBuffer> create(unsigned numberOfChannels, size_t numb erOfFrames, float sampleRate); 46 static PassRefPtr<AudioBuffer> create(unsigned numberOfChannels, size_t numb erOfFrames, float sampleRate);
47 static PassRefPtr<AudioBuffer> create(unsigned numberOfChannels, size_t numb erOfFrames, float sampleRate, ExceptionState&);
47 48
48 // Returns 0 if data is not a valid audio file. 49 // Returns 0 if data is not a valid audio file.
49 static PassRefPtr<AudioBuffer> createFromAudioFileData(const void* data, siz e_t dataSize, bool mixToMono, float sampleRate); 50 static PassRefPtr<AudioBuffer> createFromAudioFileData(const void* data, siz e_t dataSize, bool mixToMono, float sampleRate);
50 51
51 // Format 52 // Format
52 size_t length() const { return m_length; } 53 size_t length() const { return m_length; }
53 double duration() const { return length() / static_cast<double>(sampleRate() ); } 54 double duration() const { return length() / static_cast<double>(sampleRate() ); }
54 float sampleRate() const { return m_sampleRate; } 55 float sampleRate() const { return m_sampleRate; }
55 56
56 // Channel data access 57 // Channel data access
(...skipping 11 matching lines...) Expand all
68 69
69 float m_sampleRate; 70 float m_sampleRate;
70 size_t m_length; 71 size_t m_length;
71 72
72 Vector<RefPtr<Float32Array> > m_channels; 73 Vector<RefPtr<Float32Array> > m_channels;
73 }; 74 };
74 75
75 } // namespace WebCore 76 } // namespace WebCore
76 77
77 #endif // AudioBuffer_h 78 #endif // AudioBuffer_h
OLDNEW
« no previous file with comments | « LayoutTests/webaudio/dom-exceptions-expected.txt ('k') | Source/modules/webaudio/AudioBuffer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698