WebAudio createBuffer should throw error with 0 channels.

Source/modules/webaudio/AudioBuffer.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 14 matching lines @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 
 #if ENABLE(WEB_AUDIO)
 
 #include "modules/webaudio/AudioBuffer.h"
 
+#include "bindings/v8/ExceptionMessages.h"
 #include "bindings/v8/ExceptionState.h"
 #include "core/dom/ExceptionCode.h"
 #include "platform/audio/AudioBus.h"
 #include "platform/audio/AudioFileReader.h"
 #include "modules/webaudio/AudioContext.h"
 
 namespace WebCore {
 
 float AudioBuffer::minAllowedSampleRate()
 {
     // crbug.com/344375
     return 3000;
 }
 
 float AudioBuffer::maxAllowedSampleRate()
 {
     // Windows can support up to this rate.
     return 192000;
 }
 
 PassRefPtr<AudioBuffer> AudioBuffer::create(unsigned numberOfChannels, size_t numberOfFrames, float sampleRate)
 {
-    if (sampleRate < minAllowedSampleRate() || sampleRate > maxAllowedSampleRate() || numberOfChannels > AudioContext::maxNumberOfChannels() || !numberOfFrames)
+    if (sampleRate < minAllowedSampleRate() || sampleRate > maxAllowedSampleRate() || numberOfChannels > AudioContext::maxNumberOfChannels() || !numberOfChannels || !numberOfFrames)
         return nullptr;
 
     RefPtr<AudioBuffer> buffer = adoptRef(new AudioBuffer(numberOfChannels, numberOfFrames, sampleRate));
 
     if (!buffer->createdSuccessfully(numberOfChannels))
         return nullptr;
     return buffer;
 }
 
+PassRefPtr<AudioBuffer> AudioBuffer::create(unsigned numberOfChannels, size_t numberOfFrames, float sampleRate, ExceptionState& exceptionState)
+{
+    if (!numberOfChannels || numberOfChannels > AudioContext::maxNumberOfChannels()) {
+        exceptionState.throwDOMException(
+            NotSupportedError,
+            ExceptionMessages::indexOutsideRange(
+                "number of channels",
+                numberOfChannels,
+                1u,
+                ExceptionMessages::InclusiveBound,
+                AudioContext::maxNumberOfChannels(),
+                ExceptionMessages::InclusiveBound));
+        return nullptr;
+    }
+
+    if (sampleRate < AudioBuffer::minAllowedSampleRate() || sampleRate > AudioBuffer::maxAllowedSampleRate()) {
+        exceptionState.throwDOMException(
+            NotSupportedError,
+            ExceptionMessages::indexOutsideRange(
+                "sample rate",
+                sampleRate,
+                AudioBuffer::minAllowedSampleRate(),
+                ExceptionMessages::InclusiveBound,
+                AudioBuffer::maxAllowedSampleRate(),
+                ExceptionMessages::InclusiveBound));
+        return nullptr;
+    }
+
+    if (!numberOfFrames) {
+        exceptionState.throwDOMException(
+            NotSupportedError,
+            ExceptionMessages::indexExceedsMinimumBound(
+                "number of frames",
+                numberOfFrames,
+                static_cast<size_t>(0)));
+        return nullptr;
+    }
+
+    RefPtr<AudioBuffer> audioBuffer = create(numberOfChannels, numberOfFrames, sampleRate);
+
+    if (!audioBuffer.get()) {
+        exceptionState.throwDOMException(
+            NotSupportedError,
+            "createBuffer("
+            + String::number(numberOfChannels) + ", "
+            + String::number(numberOfFrames) + ", "
+            + String::number(sampleRate)
+            + ") failed.");
+    }
+
+    return audioBuffer;
+}
+
 PassRefPtr<AudioBuffer> AudioBuffer::createFromAudioFileData(const void* data, size_t dataSize, bool mixToMono, float sampleRate)
 {
     RefPtr<AudioBus> bus = createBusFromInMemoryAudioFile(data, dataSize, mixToMono, sampleRate);
     if (bus.get()) {
         RefPtr<AudioBuffer> buffer = adoptRef(new AudioBuffer(bus.get()));
         if (buffer->createdSuccessfully(bus->numberOfChannels()))
             return buffer;
     }
 
     return nullptr;
@@ skipping 68 matching lines @@
 {
     for (unsigned i = 0; i < m_channels.size(); ++i) {
         if (getChannelData(i))
             getChannelData(i)->zeroRange(0, length());
     }
 }
 
 } // namespace WebCore
 
 #endif // ENABLE(WEB_AUDIO)