Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: pkg/analyzer_cli/lib/src/build_mode.dart

Issue 2356523002: Remove fallback mode and corresponding cli flag. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/summary/summarize_elements.dart ('k') | pkg/analyzer_cli/lib/src/options.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer_cli/lib/src/build_mode.dart
diff --git a/pkg/analyzer_cli/lib/src/build_mode.dart b/pkg/analyzer_cli/lib/src/build_mode.dart
index a1aa4384d3da98a548bfdaf12bc38f57cdd8b89c..8992a10dcb228c69b4ae4e031bd280d770494eb1 100644
--- a/pkg/analyzer_cli/lib/src/build_mode.dart
+++ b/pkg/analyzer_cli/lib/src/build_mode.dart
@@ -192,13 +192,7 @@ class BuildMode {
excludeHashes: options.buildSummaryExcludeInformative &&
options.buildSummaryOutputSemantic == null);
if (_shouldOutputSummary) {
- if (!options.buildSummaryFallback) {
- _serializeAstBasedSummary(explicitSources);
- } else {
- for (Source source in explicitSources) {
- assembler.addFallbackUnit(source);
- }
- }
+ _serializeAstBasedSummary(explicitSources);
// Write the whole package bundle.
assembler.recordDependencies(summaryDataStore);
PackageBundleBuilder bundle = assembler.assemble();
« no previous file with comments | « pkg/analyzer/lib/src/summary/summarize_elements.dart ('k') | pkg/analyzer_cli/lib/src/options.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698