Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2356483002: PPC/s390: Record call counts also for megamorphic calls. (Closed)

Created:
4 years, 3 months ago by Kelvin Li
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: Record call counts also for megamorphic calls. Port: 2ab3fcf42f0cf04896b26bf23bc3809d8835fd39 Original commit message: To make better inlining decisions, it's good to have call counts for poly/mega-morphic cases. This CL makes it work for calls, and another will follow to better unify the code between constructor calls and normal calls (and thence, to record megamorphic call counts there as well). R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= Committed: https://crrev.com/47f203e409ef8c15d7225ab3779d85c1417d4c25 Cr-Commit-Position: refs/heads/master@{#39517}

Patch Set 1 #

Patch Set 2 : PPC/s390: Record call counts also for megamorphic calls. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -34 lines) Patch
M src/ppc/code-stubs-ppc.cc View 8 chunks +25 lines, -17 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 8 chunks +26 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
john.yan
lgtm
4 years, 3 months ago (2016-09-19 20:07:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356483002/20001
4 years, 3 months ago (2016-09-19 20:30:29 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-19 21:09:54 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 21:10:19 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/47f203e409ef8c15d7225ab3779d85c1417d4c25
Cr-Commit-Position: refs/heads/master@{#39517}

Powered by Google App Engine
This is Rietveld 408576698