Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2356463002: Implements BidirectionalStreamSpdyImpl::GetLoadTimingInfo (Closed)

Created:
4 years, 3 months ago by xunjieli
Modified:
4 years, 3 months ago
Reviewers:
Bence
CC:
chromium-reviews, cbentzel+watch_chromium.org, mef
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implements BidirectionalStreamSpdyImpl::GetLoadTimingInfo This CL adds an implementation of GetLoadTimingInfo in BidirectionalStreamSpdyImpl. This is a part of the effort to expose timing metrics to net embedders. BUG=648346 Committed: https://crrev.com/6d0b944d77930676e355406f795d6f51fe49daec Cr-Commit-Position: refs/heads/master@{#419938}

Patch Set 1 : self review #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -12 lines) Patch
M net/spdy/bidirectional_stream_spdy_impl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/spdy/bidirectional_stream_spdy_impl.cc View 3 chunks +16 lines, -2 lines 0 comments Download
M net/spdy/bidirectional_stream_spdy_impl_unittest.cc View 8 chunks +129 lines, -10 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
xunjieli
Bence, PTAL. Thanks!
4 years, 3 months ago (2016-09-20 14:38:59 UTC) #10
Bence
LGTM
4 years, 3 months ago (2016-09-20 15:43:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356463002/100001
4 years, 3 months ago (2016-09-21 00:33:44 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:100001)
4 years, 3 months ago (2016-09-21 01:54:36 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 01:56:41 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6d0b944d77930676e355406f795d6f51fe49daec
Cr-Commit-Position: refs/heads/master@{#419938}

Powered by Google App Engine
This is Rietveld 408576698