Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 2356443002: Set client_id and client_version in requests sent to SafeBrowsing (Closed)

Created:
4 years, 3 months ago by vakh (use Gerrit instead)
Modified:
4 years, 3 months ago
Reviewers:
woz, Nathan Parker
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set client_id and client_version in requests sent to SafeBrowsing BUG=647819, 543161 Committed: https://crrev.com/1cce0073562c8d6f81096ea36f6c77ad5f1453d9 Cr-Commit-Position: refs/heads/master@{#419820}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Make GetBase64SerializedUpdateRequestProto non static #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -45 lines) Patch
M components/safe_browsing_db/v4_get_hash_protocol_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/safe_browsing_db/v4_get_hash_protocol_manager_unittest.cc View 1 chunk +10 lines, -8 lines 0 comments Download
M components/safe_browsing_db/v4_protocol_manager_util.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/safe_browsing_db/v4_protocol_manager_util.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M components/safe_browsing_db/v4_update_protocol_manager.h View 1 2 chunks +4 lines, -5 lines 0 comments Download
M components/safe_browsing_db/v4_update_protocol_manager.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download
M components/safe_browsing_db/v4_update_protocol_manager_unittest.cc View 1 3 chunks +20 lines, -25 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
vakh (use Gerrit instead)
4 years, 3 months ago (2016-09-19 19:02:17 UTC) #4
Nathan Parker
lgtm https://codereview.chromium.org/2356443002/diff/1/components/safe_browsing_db/v4_update_protocol_manager.h File components/safe_browsing_db/v4_update_protocol_manager.h (right): https://codereview.chromium.org/2356443002/diff/1/components/safe_browsing_db/v4_update_protocol_manager.h#newcode103 components/safe_browsing_db/v4_update_protocol_manager.h:103: const StoreStateMap& store_state_map, Would it be cleaner to ...
4 years, 3 months ago (2016-09-20 00:54:36 UTC) #8
vakh (use Gerrit instead)
Make GetBase64SerializedUpdateRequestProto non static
4 years, 3 months ago (2016-09-20 17:36:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356443002/20001
4 years, 3 months ago (2016-09-20 17:37:30 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-20 18:26:01 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 18:29:46 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1cce0073562c8d6f81096ea36f6c77ad5f1453d9
Cr-Commit-Position: refs/heads/master@{#419820}

Powered by Google App Engine
This is Rietveld 408576698