Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: components/offline_pages/background/request_queue_in_memory_store.cc

Issue 2356433004: [Offline pages] Extracting AddRequest method in RequestQueueStore (Closed)
Patch Set: Addressing feedback plus attempt at fixing compilation issue" Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/background/request_queue_in_memory_store.h" 5 #include "components/offline_pages/background/request_queue_in_memory_store.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/location.h" 8 #include "base/location.h"
9 #include "base/threading/thread_task_runner_handle.h" 9 #include "base/threading/thread_task_runner_handle.h"
10 #include "components/offline_pages/background/save_page_request.h" 10 #include "components/offline_pages/background/save_page_request.h"
(...skipping 10 matching lines...) Expand all
21 for (const auto& id_request_pair : requests_) { 21 for (const auto& id_request_pair : requests_) {
22 std::unique_ptr<SavePageRequest> request( 22 std::unique_ptr<SavePageRequest> request(
23 new SavePageRequest(id_request_pair.second)); 23 new SavePageRequest(id_request_pair.second));
24 result_requests.push_back(std::move(request)); 24 result_requests.push_back(std::move(request));
25 } 25 }
26 base::ThreadTaskRunnerHandle::Get()->PostTask( 26 base::ThreadTaskRunnerHandle::Get()->PostTask(
27 FROM_HERE, 27 FROM_HERE,
28 base::Bind(callback, true, base::Passed(std::move(result_requests)))); 28 base::Bind(callback, true, base::Passed(std::move(result_requests))));
29 } 29 }
30 30
31 void RequestQueueInMemoryStore::AddRequest(const SavePageRequest& request,
32 const AddCallback& callback) {
33 RequestsMap::iterator iter = requests_.find(request.request_id());
34 ItemActionStatus status;
35 if (iter == requests_.end()) {
36 requests_.insert(std::make_pair(request.request_id(), request));
37 status = ItemActionStatus::SUCCESS;
38 } else {
39 status = ItemActionStatus::ALREADY_EXISTS;
40 }
41
42 base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
43 base::Bind(callback, status));
44 }
45
31 void RequestQueueInMemoryStore::AddOrUpdateRequest( 46 void RequestQueueInMemoryStore::AddOrUpdateRequest(
32 const SavePageRequest& request, 47 const SavePageRequest& request,
33 const UpdateCallback& callback) { 48 const UpdateCallback& callback) {
34 RequestsMap::iterator iter = requests_.find(request.request_id()); 49 RequestsMap::iterator iter = requests_.find(request.request_id());
35 if (iter != requests_.end()) 50 if (iter != requests_.end())
36 requests_.erase(iter); 51 requests_.erase(iter);
37 requests_.insert(std::make_pair(request.request_id(), request)); 52 requests_.insert(std::make_pair(request.request_id(), request));
38 base::ThreadTaskRunnerHandle::Get()->PostTask( 53 base::ThreadTaskRunnerHandle::Get()->PostTask(
39 FROM_HERE, base::Bind(callback, UpdateStatus::UPDATED)); 54 FROM_HERE, base::Bind(callback, UpdateStatus::UPDATED));
40 } 55 }
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 base::Bind(callback, results, base::Passed(std::move(requests)))); 112 base::Bind(callback, results, base::Passed(std::move(requests))));
98 } 113 }
99 114
100 void RequestQueueInMemoryStore::Reset(const ResetCallback& callback) { 115 void RequestQueueInMemoryStore::Reset(const ResetCallback& callback) {
101 requests_.clear(); 116 requests_.clear();
102 base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, 117 base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
103 base::Bind(callback, true)); 118 base::Bind(callback, true));
104 } 119 }
105 120
106 } // namespace offline_pages 121 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698