Fix overscroll getting kicked in on non-precise wheel scrolls

Fix overscroll getting kicked in on non-precise wheel scrolls

Seems a conditional was completely wrong. Write a unit test to ensure
the correct behaviour is maintained.

BUG=630014
Committed: https://crrev.com/72ca9ac43f9b025746520bdbe22a6a3e5dd33399
Cr-Commit-Position: refs/heads/master@{#420212}

[dtapuska, 2016-09-20 16:21:34]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 16:21:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 16:49:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 16:49:52]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[dtapuska, 2016-09-20 17:12:16]

dtapuska@chromium.org changed reviewers:
+ sadrul@chromium.org

[sadrul, 2016-09-21 03:33:17]

https://codereview.chromium.org/2356433003/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/overscroll_controller.cc (right):

https://codereview.chromium.org/2356433003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/overscroll_controller.cc:54: return true;
Do you even need this special case here? Would the following not work for both
touchscreen and touchpad scrolls?

[dtapuska, 2016-09-21 14:56:03]

On 2016/09/21 03:33:17, sadrul wrote:
>
https://codereview.chromium.org/2356433003/diff/1/content/browser/renderer_ho...
> File content/browser/renderer_host/overscroll_controller.cc (right):
> 
>
https://codereview.chromium.org/2356433003/diff/1/content/browser/renderer_ho...
> content/browser/renderer_host/overscroll_controller.cc:54: return true;
> Do you even need this special case here? Would the following not work for both
> touchscreen and touchpad scrolls?

done

[dtapuska, 2016-09-21 14:56:09]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 14:56:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 16:46:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 16:46:32]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-09-22 00:18:24]

lgtm

[dtapuska, 2016-09-22 00:19:46]

The CQ bit was checked by dtapuska@chromium.org

[commit-bot: I haz the power, 2016-09-22 00:20:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 00:27:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-22 00:31:42]

Description was changed from

==========
Fix overscroll getting kicked in on non-precise wheel scrolls

Seems a conditional was completely wrong. Write a unit test to ensure
the correct behaviour is maintained.

BUG=630014
==========

to

==========
Fix overscroll getting kicked in on non-precise wheel scrolls

Seems a conditional was completely wrong. Write a unit test to ensure
the correct behaviour is maintained.

BUG=630014

Committed: https://crrev.com/72ca9ac43f9b025746520bdbe22a6a3e5dd33399
Cr-Commit-Position: refs/heads/master@{#420212}
==========

[commit-bot: I haz the power, 2016-09-22 00:31:43]

Patchset 2 (id:??) landed as
https://crrev.com/72ca9ac43f9b025746520bdbe22a6a3e5dd33399
Cr-Commit-Position: refs/heads/master@{#420212}