Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/Panel.js

Issue 2356423002: [DevTools] Turn WebInspector.Panel into a web component.
Patch Set: partial fixes Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/Panel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Panel.js b/third_party/WebKit/Source/devtools/front_end/ui/Panel.js
index c03b3e39b201bf0874c6700304bad2fac3fc1546..11ce92179493c36546c0309791a8d485b6814604 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/Panel.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/Panel.js
@@ -28,16 +28,17 @@
/**
* @extends {WebInspector.VBox}
+ * @param {string} name
+ * @param {boolean=} iAmExtensionPanelCannotBeInShadow
* @constructor
*/
-WebInspector.Panel = function(name)
+WebInspector.Panel = function(name, iAmExtensionPanelCannotBeInShadow)
{
- WebInspector.VBox.call(this);
+ WebInspector.VBox.call(this, !iAmExtensionPanelCannotBeInShadow);
- this.element.classList.add("panel");
- this.element.setAttribute("role", "tabpanel");
- this.element.setAttribute("aria-label", name);
- this.element.classList.add(name);
+ this.contentElement.classList.add("panel");
+ this.contentElement.setAttribute("role", "tabpanel");
+ this.contentElement.setAttribute("aria-label", name);
this._panelName = name;
this._shortcuts = /** !Object.<number, function(Event=):boolean> */ ({});
@@ -100,10 +101,10 @@ WebInspector.Panel.prototype = {
showInfobar: function(infobar)
{
infobar.setCloseCallback(this._onInfobarClosed.bind(this, infobar));
- if (this.element.firstChild)
- this.element.insertBefore(infobar.element, this.element.firstChild);
+ if (this.contentElement.firstChild)
+ this.contentElement.insertBefore(infobar.element, this.contentElement.firstChild);
else
- this.element.appendChild(infobar.element);
+ this.contentElement.appendChild(infobar.element);
infobar.setParentView(this);
this.doResize();
},
@@ -131,7 +132,7 @@ WebInspector.PanelWithSidebar = function(name, defaultWidth)
WebInspector.Panel.call(this, name);
this._panelSplitWidget = new WebInspector.SplitWidget(true, false, this._panelName + "PanelSplitViewState", defaultWidth || 200);
- this._panelSplitWidget.show(this.element);
+ this._panelSplitWidget.show(this.contentElement);
this._mainWidget = new WebInspector.VBox();
this._panelSplitWidget.setMainWidget(this._mainWidget);

Powered by Google App Engine
This is Rietveld 408576698