third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js - Issue 2356423002: [DevTools] Turn WebInspector.Panel into a web component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js

Issue 2356423002: [DevTools] Turn WebInspector.Panel into a web component.

Patch Set: partial fixes Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js

index 973cf7b12f273bdb82d4bfb0e5992a9fc873d01f..77aef7f35bcb71c7abf1f602a5f01536754577f4 100644

--- a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js

@@ -39,14 +39,14 @@

WebInspector.ExtensionPanel = function(server, panelName, id, pageURL)

{

- WebInspector.Panel.call(this, panelName);

+ WebInspector.Panel.call(this, panelName, true);

this._server = server;

this._id = id;

this.setHideOnDetach();

- this._panelToolbar = new WebInspector.Toolbar("hidden", this.element);

+ this._panelToolbar = new WebInspector.Toolbar("hidden", this.contentElement);

this._searchableView = new WebInspector.SearchableView(this);

- this._searchableView.show(this.element);

+ this._searchableView.show(this.contentElement);

var extensionView = new WebInspector.ExtensionView(server, this._id, pageURL, "extension");

extensionView.show(this._searchableView.element);