third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/click-gutter-breakpoint.html - Issue 2356423002: [DevTools] Turn WebInspector.Panel into a web component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/click-gutter-breakpoint.html

Issue 2356423002: [DevTools] Turn WebInspector.Panel into a web component.

Patch Set: partial fixes Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/autocomplete-general.html ('k') | third_party/WebKit/Source/devtools/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/click-gutter-breakpoint.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/click-gutter-breakpoint.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/click-gutter-breakpoint.html

index 9f77daa5819dfcd52fe82365c0e8a13a33d21cf1..3cea1625004a713b2158eba003ccd15173d86128 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/click-gutter-breakpoint.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/click-gutter-breakpoint.html

@@ -6,9 +6,11 @@

function test()

{

+ var panel = WebInspector.panels.sources;

function clickCodeMirrorLineNumber(lineNumber)

{

- var element = Array.from(document.getElementsByClassName("CodeMirror-linenumber")).filter(x => x.textContent === (lineNumber + 1).toString())[0];

+ var element = Array.from(panel.contentElement.querySelectorAll(".CodeMirror-linenumber")).filter(x => x.textContent === (lineNumber + 1).toString())[0];

if (!element) {

InspectorTest.addResult("CodeMirror Gutter Not Found:" + lineNumber);

InspectorTest.completeDebuggerTest();

@@ -22,10 +24,6 @@ function test()

}

WebInspector.breakpointManager._storage._breakpoints = {};

- var panel = WebInspector.panels.sources;

- var scriptFormatter;

- var formattedSourceFrame;

InspectorTest.startDebuggerTest(() => InspectorTest.showScriptSource("click-breakpoints.js", didShowScriptSource));