Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: third_party/WebKit/LayoutTests/inspector/console/console-viewport-selection.html

Issue 2356423002: [DevTools] Turn WebInspector.Panel into a web component.
Patch Set: partial fixes Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/console/console-viewport-selection.html
diff --git a/third_party/WebKit/LayoutTests/inspector/console/console-viewport-selection.html b/third_party/WebKit/LayoutTests/inspector/console/console-viewport-selection.html
index c991d790704d409814f96ecc1a36075efb3eb806..5b0110f7a0d71ae1b669600f77ce5dce7eb0b5d7 100644
--- a/third_party/WebKit/LayoutTests/inspector/console/console-viewport-selection.html
+++ b/third_party/WebKit/LayoutTests/inspector/console/console-viewport-selection.html
@@ -121,7 +121,7 @@ function test()
function testRemoveSelection(next)
{
- var selection = window.getSelection();
+ var selection = viewport.element.getComponentSelection();
selection.removeAllRanges();
dumpSelectionModel();
dumpViewportRenderedItems();
@@ -161,7 +161,7 @@ function test()
while (blueSpan.nodeName !== "SPAN" || blueSpan.textContent !== "world")
blueSpan = blueSpan.traverseNextNode();
- window.getSelection().setBaseAndExtent(blueSpan, 0, blueSpan, blueSpan.textContent.length);
+ viewport.element.getComponentSelection().setBaseAndExtent(blueSpan, 0, blueSpan, blueSpan.textContent.length);
InspectorTest.addResult("Selected text: " + viewport._selectedText());
next();
},
@@ -173,7 +173,7 @@ function test()
// Set some initial selection in console.
var base = consoleView.itemElement(messagesCount - 2).element();
var extent = consoleView.itemElement(messagesCount - 1).element();
- window.getSelection().setBaseAndExtent(base, 0, extent, 0);
+ viewport.element.getComponentSelection().setBaseAndExtent(base, 0, extent, 0);
// Try to select all messages.
document.execCommand("selectAll");
@@ -193,13 +193,13 @@ function test()
var textNodeBase = consoleView.itemElement(1).element().traverseNextTextNode();
var textNodeExtent = consoleView.itemElement(2).element().traverseNextTextNode();
- window.getSelection().setBaseAndExtent(nonTextNodeBase, 0, nonTextNodeExtent, 0);
+ viewport.element.getComponentSelection().setBaseAndExtent(nonTextNodeBase, 0, nonTextNodeExtent, 0);
InspectorTest.addResult("Selected text: " + viewport._selectedText());
- window.getSelection().setBaseAndExtent(textNodeBase, 0, nonTextNodeExtent, 0);
+ viewport.element.getComponentSelection().setBaseAndExtent(textNodeBase, 0, nonTextNodeExtent, 0);
InspectorTest.addResult("Selected text: " + viewport._selectedText());
- window.getSelection().setBaseAndExtent(nonTextNodeBase, 0, textNodeExtent, 0);
+ viewport.element.getComponentSelection().setBaseAndExtent(nonTextNodeBase, 0, textNodeExtent, 0);
InspectorTest.addResult("Selected text: " + viewport._selectedText());
next();
@@ -248,7 +248,7 @@ function test()
function emulateShiftClickOnMessage(messageIndex)
{
viewport.refresh();
- var selection = window.getSelection();
+ var selection = viewport.element.getComponentSelection();
if (!selection || !selection.rangeCount) {
InspectorTest.addResult("FAILURE: There's no selection");
return;
@@ -287,7 +287,7 @@ function test()
var from = selectionContainerAndOffset(consoleView.itemElement(fromMessage).element(), fromTextOffset);
var to = selectionContainerAndOffset(consoleView.itemElement(toMessage).element(), toTextOffset);
- window.getSelection().setBaseAndExtent(from.container, from.offset, to.container, to.offset);
+ viewport.element.getComponentSelection().setBaseAndExtent(from.container, from.offset, to.container, to.offset);
viewport.refresh();
}
}

Powered by Google App Engine
This is Rietveld 408576698