Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: pkg/dev_compiler/test/codegen/corelib/list_reversed_test.dart

Issue 2356413002: Fix tests (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/test/codegen/corelib/list_reversed_test.dart
diff --git a/pkg/dev_compiler/test/codegen/corelib/list_reversed_test.dart b/pkg/dev_compiler/test/codegen/corelib/list_reversed_test.dart
index ea1e78017b923d1aeca76ec2db9cbd7f8efc4dbe..05dba7a474af5cd5f8a3440ed9a87df9d4a5682c 100644
--- a/pkg/dev_compiler/test/codegen/corelib/list_reversed_test.dart
+++ b/pkg/dev_compiler/test/codegen/corelib/list_reversed_test.dart
@@ -16,12 +16,12 @@ class ThrowMarker {
void testOperations() {
// Comparison lists.
- List l = const [1, 2, 3, 4, 5, 6, 7, 8, 9, 10];
- List r = const [10, 9, 8, 7, 6, 5, 4, 3, 2, 1];
+ var l = const [1, 2, 3, 4, 5, 6, 7, 8, 9, 10];
+ var r = const [10, 9, 8, 7, 6, 5, 4, 3, 2, 1];
// A base list that starts out like l.
- List base = l.toList();
+ var base = l.toList();
// A lazy reverse of base.
- Iterable reversed = base.reversed;
+ var reversed = base.reversed;
Expect.listEquals(r, reversed.toList());
Expect.listEquals(l, reversed.toList().reversed.toList());
@@ -49,7 +49,7 @@ void testOperations() {
reversed.skip(2).toList().reversed.skip(2).toList().reversed.toList());
- void testList(List list) {
+ void testList(List<int> list) {
var throws = const ThrowMarker();
void testEquals(v1, v2, path) {
if (v1 is Iterable) {
@@ -71,12 +71,12 @@ void testOperations() {
}
}
- void testOp(operation(Iterable reversedList), name) {
- List reversedList = new List(list.length);
+ void testOp(operation(Iterable<int> reversedList), name) {
+ var reversedList = new List<int>(list.length);
for (int i = 0; i < list.length; i++) {
reversedList[i] = list[list.length - 1 - i];
}
- Iterable reversed = list.reversed;
+ var reversed = list.reversed;
var expect;
try {
expect = operation(reversedList);
@@ -107,7 +107,7 @@ void testOperations() {
testOp((i) => i.every((n) => n < 5), "every<5");
testOp((i) => i.every((n) => n < 10), "every<10");
testOp((i) => i.reduce((a, b) => a + b), "reduce-sum");
- testOp((i) => i.fold(0, (a, b) => a + b), "fold-sum");
+ testOp((i) => i.fold/*<int>*/(0, (a, b) => a + b), "fold-sum");
testOp((i) => i.join("-"), "join-");
testOp((i) => i.join(""), "join");
testOp((i) => i.join(), "join-null");

Powered by Google App Engine
This is Rietveld 408576698