Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2356413002: Fix tests (Closed)

Created:
4 years, 2 months ago by vsm
Modified:
4 years, 1 month ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix tests This fixed the original 5 static errors from this morning. TBR=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/8e943b8c59e2f0da15b0d90d9da05012f3364386

Patch Set 1 #

Total comments: 2

Patch Set 2 : Mark test strong clean for DDC #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
pkg/dev_compiler/test/not_yet_strong_tests.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
vsm
Committed patchset #1 (id:1) manually as 8e943b8c59e2f0da15b0d90d9da05012f3364386 (presubmit successful).
4 years, 2 months ago (2016-09-21 21:00:04 UTC) #2
Jennifer Messerly
4 years, 2 months ago (2016-09-21 21:09:04 UTC) #3
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/2356413002/diff/1/pkg/dev_compiler/lib/js/amd...
File pkg/dev_compiler/lib/js/amd/dart_sdk.js (right):

https://codereview.chromium.org/2356413002/diff/1/pkg/dev_compiler/lib/js/amd...
pkg/dev_compiler/lib/js/amd/dart_sdk.js:19112: +        if
(dart.test(this[_isComplete])) return new async._Future.immediate(this);
interesting change here huh? (possibly fine, I'd have to look at the SDK
sources)

https://codereview.chromium.org/2356413002/diff/1/pkg/dev_compiler/tool/sdk_e...
File pkg/dev_compiler/tool/sdk_expected_errors.txt (right):

https://codereview.chromium.org/2356413002/diff/1/pkg/dev_compiler/tool/sdk_e...
pkg/dev_compiler/tool/sdk_expected_errors.txt:3: [error] The return type
'_Future' is not a 'Future<T>', as defined by the method 'timeout'.
(dart:async/future_impl.dart, line 705, col 29)
ah interesting

Powered by Google App Engine
This is Rietveld 408576698