Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 23564006: Remove unneeded includes of PasswordForm in the content layer (Closed)

Created:
7 years, 3 months ago by blundell
Modified:
7 years, 3 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Garrett Casto
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove unneeded includes of PasswordForm in the content layer Follow-up to https://chromiumcodereview.appspot.com/19705013. BUG=263121 R=jam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220713

Patch Set 1 #

Patch Set 2 : Remove include of conversion_utils #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M content/renderer/internal_document_state_data.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
blundell
AFAICT, this include was in fact never needed (it was introduced in https://chromiumcodereview.appspot.com/13722005/).
7 years, 3 months ago (2013-08-30 12:07:10 UTC) #1
blundell
On 2013/08/30 12:07:10, blundell wrote: > AFAICT, this include was in fact never needed (it ...
7 years, 3 months ago (2013-08-30 12:37:03 UTC) #2
jam
lgtm
7 years, 3 months ago (2013-08-30 16:18:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/23564006/7001
7 years, 3 months ago (2013-08-30 19:07:46 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-08-31 01:20:04 UTC) #5
Message was sent while issue was closed.
Change committed as 220713

Powered by Google App Engine
This is Rietveld 408576698