Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2356393002: Add ExecutionMode/SequenceToken and TaskPriority as arguments of TaskScheduler tasks in tracing (Closed)

Created:
4 years, 3 months ago by gab
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, tracing+reviews_chromium.org, gab+watch_chromium.org, robliao+watch_chromium.org, fdoray+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ExecutionMode/SequenceToken and TaskPriority as arguments of TaskScheduler tasks in tracing This CL requires https://codereview.chromium.org/2374193002 as a prerequisite. That CL has been dropped for the time being and this CL is thus merely meant to show how this could be done if TRACE_TASK_EXECUTION didn't use up all (2) trace event parameters already. Meanwhile, TaskScheduler will report its args using another trace event (resulting in two events per tasks when the "taskscheduler" tracing category is enabled..): https://codereview.chromium.org/2392903002. BUG=649084

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -6 lines) Patch
M base/sequence_token.h View 2 chunks +5 lines, -0 lines 0 comments Download
M base/sequence_token.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M base/sequence_token_unittest.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M base/task_scheduler/task_tracker.cc View 3 chunks +81 lines, -1 line 0 comments Download
M base/trace_event/common/trace_event_common.h View 1 chunk +3 lines, -1 line 0 comments Download
M base/trace_event/trace_event.h View 1 chunk +6 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (7 generated)
gab
Patchset #1 (id:1) has been deleted
4 years, 2 months ago (2016-10-04 13:00:09 UTC) #1
gab
Patchset #1 (id:20001) has been deleted
4 years, 2 months ago (2016-10-04 13:00:15 UTC) #2
gab
Description was changed from ========== Add ExecutionMode and SequenceToken as arguments of TaskScheduler tasks in ...
4 years, 2 months ago (2016-10-04 13:00:46 UTC) #3
gab
Description was changed from ========== Add ExecutionMode/SequenceToken and TaskPriority as arguments of TaskScheduler tasks in ...
4 years, 2 months ago (2016-10-04 13:02:33 UTC) #4
gab
Description was changed from ========== Add ExecutionMode/SequenceToken and TaskPriority as arguments of TaskScheduler tasks in ...
4 years, 2 months ago (2016-10-04 13:02:52 UTC) #5
gab
Description was changed from ========== Add ExecutionMode/SequenceToken and TaskPriority as arguments of TaskScheduler tasks in ...
4 years, 2 months ago (2016-10-04 13:08:10 UTC) #6
gab
4 years, 2 months ago (2016-10-04 13:41:04 UTC) #7
Message was sent while issue was closed.
Description was changed from

==========
Add ExecutionMode/SequenceToken and TaskPriority as arguments of TaskScheduler
tasks in tracing

This CL requires https://codereview.chromium.org/2374193002 as a prerequisite.
That CL has been dropped for the time being and this CL is thus merely meant to
show how
this could be done if TRACE_TASK_EXECUTION didn't use up all (2) trace event
parameters
already. Meanwhile, TaskScheduler will report its args using another trace event
(resulting
in two events per tasks when the "taskscheduler" tracing category is enabled..).

BUG=649084
==========

to

==========
Add ExecutionMode/SequenceToken and TaskPriority as arguments of TaskScheduler
tasks in tracing

This CL requires https://codereview.chromium.org/2374193002 as a prerequisite.
That CL has been dropped for the time being and this CL is thus merely meant to
show how
this could be done if TRACE_TASK_EXECUTION didn't use up all (2) trace event
parameters
already. Meanwhile, TaskScheduler will report its args using another trace event
(resulting
in two events per tasks when the "taskscheduler" tracing category is enabled..):
https://codereview.chromium.org/2392903002.

BUG=649084
==========

Powered by Google App Engine
This is Rietveld 408576698