Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2356383003: Delete MessageLoop::Run()/RunUntilIdle(). (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 2 months ago
Reviewers:
dcheng
CC:
chromium-reviews, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete MessageLoop::Run()/RunUntilIdle(). These methods are deprecated and no longer used in Chrome. base::RunLoop must be used instead. e.g.: Replace message_loop.Run(); With base::RunLoop run_loop; // Pass |run_loop.QuitClosure()| to an object/task // that will quit the RunLoop when appropriate. run_loop.Run(); Replace message_loop.RunUntilIdle(); With base::RunLoop().RunUntilIdle(); BUG=616447 Committed: https://crrev.com/21ffea60f63de8446367264703e6b3e2fa5a2c4e Cr-Commit-Position: refs/heads/master@{#421068}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -35 lines) Patch
M base/message_loop/message_loop.h View 3 chunks +0 lines, -23 lines 0 comments Download
M base/message_loop/message_loop.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 33 (25 generated)
fdoray
PTAL
4 years, 2 months ago (2016-09-26 15:39:57 UTC) #18
dcheng
LGTM
4 years, 2 months ago (2016-09-26 17:20:39 UTC) #21
fdoray
Passed ios_internal smoke test.
4 years, 2 months ago (2016-09-26 20:09:58 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356383003/80001
4 years, 2 months ago (2016-09-26 20:10:50 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/299884)
4 years, 2 months ago (2016-09-26 21:54:38 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356383003/80001
4 years, 2 months ago (2016-09-26 22:10:29 UTC) #29
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-09-27 01:24:51 UTC) #31
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 01:26:53 UTC) #33
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/21ffea60f63de8446367264703e6b3e2fa5a2c4e
Cr-Commit-Position: refs/heads/master@{#421068}

Powered by Google App Engine
This is Rietveld 408576698