|
|
Chromium Code Reviews
DescriptionDelete MessageLoop::Run()/RunUntilIdle().
These methods are deprecated and no longer used in Chrome.
base::RunLoop must be used instead.
e.g.:
Replace
message_loop.Run();
With
base::RunLoop run_loop;
// Pass |run_loop.QuitClosure()| to an object/task
// that will quit the RunLoop when appropriate.
run_loop.Run();
Replace
message_loop.RunUntilIdle();
With
base::RunLoop().RunUntilIdle();
BUG=616447
Committed: https://crrev.com/21ffea60f63de8446367264703e6b3e2fa5a2c4e
Cr-Commit-Position: refs/heads/master@{#421068}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase #Patch Set 4 : rebase #Patch Set 5 : rebase #
Messages
Total messages: 33 (25 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Delete MessageLoop::Run()/RunUntilIdle(). These methods are deprecated and no longer used in Chrome. RunLoop must be used instead. BUG=616447 ========== to ========== Delete MessageLoop::Run()/RunUntilIdle(). These methods are deprecated and no longer used in Chrome. base::RunLoop must be used instead. BUG=616447 ==========
Description was changed from ========== Delete MessageLoop::Run()/RunUntilIdle(). These methods are deprecated and no longer used in Chrome. base::RunLoop must be used instead. BUG=616447 ========== to ========== Delete MessageLoop::Run()/RunUntilIdle(). These methods are deprecated and no longer used in Chrome. base::RunLoop must be used instead. e.g.: Replace message_loop.Run(); With base::RunLoop run_loop; // Pass |run_loop.QuitClosure()| to an object/task // that will quit the RunLoop when appropriate. run_loop.Run(); Replace message_loop.RunUntilIdle(); With base::RunLoop().RunUntilIdle(); BUG=616447 ==========
fdoray@chromium.org changed reviewers: + dcheng@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
Passed ios_internal smoke test.
The CQ bit was checked by fdoray@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org Link to the patchset: https://codereview.chromium.org/2356383003/#ps80001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Delete MessageLoop::Run()/RunUntilIdle(). These methods are deprecated and no longer used in Chrome. base::RunLoop must be used instead. e.g.: Replace message_loop.Run(); With base::RunLoop run_loop; // Pass |run_loop.QuitClosure()| to an object/task // that will quit the RunLoop when appropriate. run_loop.Run(); Replace message_loop.RunUntilIdle(); With base::RunLoop().RunUntilIdle(); BUG=616447 ========== to ========== Delete MessageLoop::Run()/RunUntilIdle(). These methods are deprecated and no longer used in Chrome. base::RunLoop must be used instead. e.g.: Replace message_loop.Run(); With base::RunLoop run_loop; // Pass |run_loop.QuitClosure()| to an object/task // that will quit the RunLoop when appropriate. run_loop.Run(); Replace message_loop.RunUntilIdle(); With base::RunLoop().RunUntilIdle(); BUG=616447 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Delete MessageLoop::Run()/RunUntilIdle(). These methods are deprecated and no longer used in Chrome. base::RunLoop must be used instead. e.g.: Replace message_loop.Run(); With base::RunLoop run_loop; // Pass |run_loop.QuitClosure()| to an object/task // that will quit the RunLoop when appropriate. run_loop.Run(); Replace message_loop.RunUntilIdle(); With base::RunLoop().RunUntilIdle(); BUG=616447 ========== to ========== Delete MessageLoop::Run()/RunUntilIdle(). These methods are deprecated and no longer used in Chrome. base::RunLoop must be used instead. e.g.: Replace message_loop.Run(); With base::RunLoop run_loop; // Pass |run_loop.QuitClosure()| to an object/task // that will quit the RunLoop when appropriate. run_loop.Run(); Replace message_loop.RunUntilIdle(); With base::RunLoop().RunUntilIdle(); BUG=616447 Committed: https://crrev.com/21ffea60f63de8446367264703e6b3e2fa5a2c4e Cr-Commit-Position: refs/heads/master@{#421068} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/21ffea60f63de8446367264703e6b3e2fa5a2c4e Cr-Commit-Position: refs/heads/master@{#421068} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
