Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2356373002: Update createContextualFragment behavior to latest spec (Closed)

Created:
4 years, 3 months ago by rwlbuis
Modified:
4 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update createContextualFragment behavior to latest spec Update createContextualFragment behavior to latest spec listed under [1]. This means specifically we do not throw an exception when the context node is not HTML or SVG and if initially the context element is null, we follow step 2 to create an appropriate context element to be used in step 3. Behavior matches Firefox and Safari. BUG=616760 [1] https://w3c.github.io/DOM-Parsing/#extensions-to-the-range-interface Committed: https://crrev.com/a695888f5a4372b346a2d9c2650c8d81e9a5434b Cr-Commit-Position: refs/heads/master@{#420573}

Patch Set 1 #

Patch Set 2 : V2 #

Patch Set 3 : Fix test failures #

Patch Set 4 : V4 #

Patch Set 5 : V5 #

Patch Set 6 : V6 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -17 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/Range/create-contextual-fragment-from-bodyless-xml-document-range.html View 1 2 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Range/create-contextual-fragment-from-xml-element-range.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Range.cpp View 1 2 3 4 5 1 chunk +6 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
rwlbuis
PTAL. Note that this keeps the SVG behavior introduced for crbug.com/107982.
4 years, 3 months ago (2016-09-22 21:45:33 UTC) #5
tkent
lgtm
4 years, 3 months ago (2016-09-22 23:36:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356373002/90001
4 years, 3 months ago (2016-09-23 01:02:11 UTC) #8
commit-bot: I haz the power
Committed patchset #6 (id:90001)
4 years, 3 months ago (2016-09-23 04:03:07 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 04:05:15 UTC) #12
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/a695888f5a4372b346a2d9c2650c8d81e9a5434b
Cr-Commit-Position: refs/heads/master@{#420573}

Powered by Google App Engine
This is Rietveld 408576698