Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2356363004: IME for Mus: Fix test_ime_driver related dependencies. (Closed)

Created:
4 years, 3 months ago by Hadi
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IME for Mus: Fix test_ime_driver related dependencies. test_ime_driver wasn't built when compiling //services/ui (which requires it to function properly), so text input didn't work if we built mash:all on a clean directory. This CL fixes that. BUG=548407 Committed: https://crrev.com/78aa4fdc8b8305d1800cbe95730239dd0c89149a Cr-Commit-Position: refs/heads/master@{#420452}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M services/ui/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/ime/test_ime_driver/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Hadi
PTAL.
4 years, 3 months ago (2016-09-22 17:48:53 UTC) #4
sky
LGTM - be careful here though. We don't want building ui to depend upon chrome/extensions.
4 years, 3 months ago (2016-09-22 20:19:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356363004/1
4 years, 3 months ago (2016-09-22 20:41:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 20:47:46 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 20:50:58 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78aa4fdc8b8305d1800cbe95730239dd0c89149a
Cr-Commit-Position: refs/heads/master@{#420452}

Powered by Google App Engine
This is Rietveld 408576698