Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2356363003: fix tiger b (Closed)

Created:
4 years, 3 months ago by caryclark
Modified:
4 years, 2 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix tiger b The tiger tests have uncovered numerous bugs. This CL fixes the last of them. If a pair of curves do not intersect, but have one or both ends very close to the opposite curve, consider that an intersection. TBR=reed@google.com BUG=skia:5131 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356363003 Committed: https://skia.googlesource.com/skia/+/6c3b9cdcb047afe963c7bcf34834ba2ecccacc33

Patch Set 1 #

Patch Set 2 : wip; isolate latest failure #

Patch Set 3 : wip; isolate sorter data #

Patch Set 4 : check endpoints of non-intersecting curves #

Patch Set 5 : reset debug flags #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1567 lines, -223 lines) Patch
M gyp/pathops_unittest.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/pathops/SkOpAngle.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/pathops/SkOpCoincidence.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/pathops/SkOpCoincidence.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsDebug.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 1 5 chunks +31 lines, -14 lines 0 comments Download
M src/pathops/SkPathOpsTSect.h View 1 2 3 19 chunks +65 lines, -26 lines 0 comments Download
A tests/PathOpsConicQuadIntersectionTest.cpp View 1 2 3 1 chunk +69 lines, -0 lines 0 comments Download
M tests/PathOpsCubicIntersectionTest.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M tests/PathOpsSimplifyTest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/PathOpsTSectDebug.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M tools/pathops_sorter.htm View 1 2 3 1 chunk +4 lines, -29 lines 0 comments Download
M tools/pathops_visualizer.htm View 1 7 chunks +1382 lines, -141 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356363003/80001
4 years, 2 months ago (2016-09-26 11:36:00 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Test-Android-Clang-Nexus5-GPU-Adreno330-arm-Release-GN_Android-Trybot on master.client.skia.android (JOB_FAILED, http://build.chromium.org/p/client.skia.android/builders/Test-Android-Clang-Nexus5-GPU-Adreno330-arm-Release-GN_Android-Trybot/builds/275)
4 years, 2 months ago (2016-09-26 11:51:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356363003/80001
4 years, 2 months ago (2016-09-26 12:18:33 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 12:37:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/6c3b9cdcb047afe963c7bcf34834ba2ecccacc33

Powered by Google App Engine
This is Rietveld 408576698