Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2356353002: Add layout tests to TestExpectations that are impacted by osmesa derivative issue. (Closed)

Created:
4 years, 3 months ago by bsalomon
Modified:
4 years, 3 months ago
Reviewers:
f(malita), reed1
CC:
chromium-reviews, blink-reviews, borenet
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add layout tests to TestExpectations that are impacted by osmesa derivative issue. BUG=649063 Committed: https://crrev.com/1faf350c1f030ff5f5cfd074d9f99802137e8a99 Cr-Commit-Position: refs/heads/master@{#420158}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
bsalomon
4 years, 3 months ago (2016-09-21 18:53:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356353002/1
4 years, 3 months ago (2016-09-21 18:59:35 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-21 18:59:37 UTC) #7
f(malita)
lgtm
4 years, 3 months ago (2016-09-21 19:45:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356353002/1
4 years, 3 months ago (2016-09-21 19:47:58 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 20:50:37 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 20:52:55 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1faf350c1f030ff5f5cfd074d9f99802137e8a99
Cr-Commit-Position: refs/heads/master@{#420158}

Powered by Google App Engine
This is Rietveld 408576698