Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2356343004: speed up debug dm (Closed)

Created:
4 years, 2 months ago by caryclark
Modified:
4 years, 2 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

speed up debug dm SkPathMeasure can take minutes with pathological cases. Limit the debug check to a reasonable number. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356343004 Committed: https://skia.googlesource.com/skia/+/d1d628120af11c022e88265e9bdd27eb7d5d1eb8

Patch Set 1 #

Patch Set 2 : add comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/core/SkPathMeasure.cpp View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
caryclark
4 years, 2 months ago (2016-09-21 20:32:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356343004/20001
4 years, 2 months ago (2016-09-21 20:32:12 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 2 months ago (2016-09-21 20:32:13 UTC) #5
reed1
lgtm
4 years, 2 months ago (2016-09-21 20:36:01 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-22 12:15:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d1d628120af11c022e88265e9bdd27eb7d5d1eb8

Powered by Google App Engine
This is Rietveld 408576698