Some Vulkan memory fixes and cleanup

Some Vulkan memory fixes and cleanup

* Switch back to not setting transfer_dst on all buffers
* Add some missing unit tests
* Add tracking of heap usage for debugging purposes
* Fall back to non-device-local memory if device-local allocation fails

BUG=skia:5031
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356343003

Committed: https://skia.googlesource.com/skia/+/c5850e9fdb62cc4ae5ed2b6af51aea92cac07455
Committed: https://skia.googlesource.com/skia/+/68c3d30702c8af5ae249c78b30a9ea2351f875ed

[jvanverth1, 2016-09-21 20:11:27]

Description was changed from

==========
Some Vulkan memory fixes and cleanup

* Switch back to not setting transfer_dst on all buffers
* Add some missing unit tests
* Add tracking of heap usage for debugging purposes
* Fall back to non-device-local memory if device-local allocation fails

BUG=skia:5031
==========

to

==========
Some Vulkan memory fixes and cleanup

* Switch back to not setting transfer_dst on all buffers
* Add some missing unit tests
* Add tracking of heap usage for debugging purposes
* Fall back to non-device-local memory if device-local allocation fails

BUG=skia:5031
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356343003
==========

[jvanverth1, 2016-09-21 20:13:12]

jvanverth@google.com changed reviewers:
+ brianosman@google.com, egdaniel@google.com

[egdaniel, 2016-09-22 13:25:46]

https://codereview.chromium.org/2356343003/diff/1/src/gpu/vk/GrVkMemory.cpp
File src/gpu/vk/GrVkMemory.cpp (right):

https://codereview.chromium.org/2356343003/diff/1/src/gpu/vk/GrVkMemory.cpp#n...
src/gpu/vk/GrVkMemory.cpp:99: !heap->alloc(memReqs.size, memReqs.alignment,
typeIndex, heapIndex, alloc)) {
do we need to update heap index between these?

[jvanverth1, 2016-09-22 14:14:51]

https://codereview.chromium.org/2356343003/diff/1/src/gpu/vk/GrVkMemory.cpp
File src/gpu/vk/GrVkMemory.cpp (right):

https://codereview.chromium.org/2356343003/diff/1/src/gpu/vk/GrVkMemory.cpp#n...
src/gpu/vk/GrVkMemory.cpp:99: !heap->alloc(memReqs.size, memReqs.alignment,
typeIndex, heapIndex, alloc)) {
On 2016/09/22 13:25:46, egdaniel wrote:
> do we need to update heap index between these?

Done.

[egdaniel, 2016-09-22 17:48:12]

lgtm

[jvanverth1, 2016-09-22 17:56:40]

The CQ bit was checked by jvanverth@google.com

[commit-bot: I haz the power, 2016-09-22 17:56:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 19:47:37]

Description was changed from

==========
Some Vulkan memory fixes and cleanup

* Switch back to not setting transfer_dst on all buffers
* Add some missing unit tests
* Add tracking of heap usage for debugging purposes
* Fall back to non-device-local memory if device-local allocation fails

BUG=skia:5031
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356343003
==========

to

==========
Some Vulkan memory fixes and cleanup

* Switch back to not setting transfer_dst on all buffers
* Add some missing unit tests
* Add tracking of heap usage for debugging purposes
* Fall back to non-device-local memory if device-local allocation fails

BUG=skia:5031
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356343003

Committed:
https://skia.googlesource.com/skia/+/c5850e9fdb62cc4ae5ed2b6af51aea92cac07455
==========

[commit-bot: I haz the power, 2016-09-22 19:47:38]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c5850e9fdb62cc4ae5ed2b6af51aea92cac07455

[jvanverth1, 2016-09-22 20:45:09]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2358123004/ by jvanverth@google.com.

The reason for reverting is: fHeapIndex is not used in release, need to hide
behind SK_DEBUG. Failing on
Perf-Android-Clang-NVIDIA_Shield-GPU-TegraX1-arm64-Release-GN_Android_Vulkan..

[jvanverth1, 2016-09-23 14:03:23]

Description was changed from

==========
Some Vulkan memory fixes and cleanup

* Switch back to not setting transfer_dst on all buffers
* Add some missing unit tests
* Add tracking of heap usage for debugging purposes
* Fall back to non-device-local memory if device-local allocation fails

BUG=skia:5031
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356343003

Committed:
https://skia.googlesource.com/skia/+/c5850e9fdb62cc4ae5ed2b6af51aea92cac07455
==========

to

==========
Some Vulkan memory fixes and cleanup

* Switch back to not setting transfer_dst on all buffers
* Add some missing unit tests
* Add tracking of heap usage for debugging purposes
* Fall back to non-device-local memory if device-local allocation fails

BUG=skia:5031
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356343003

Committed:
https://skia.googlesource.com/skia/+/c5850e9fdb62cc4ae5ed2b6af51aea92cac07455
==========

[jvanverth1, 2016-09-23 17:14:22]

The CQ bit was checked by jvanverth@google.com

[jvanverth1, 2016-09-23 17:14:22]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/2356343003/#ps40001
(title: "Fix release build")

[commit-bot: I haz the power, 2016-09-23 17:14:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 17:30:05]

Description was changed from

==========
Some Vulkan memory fixes and cleanup

* Switch back to not setting transfer_dst on all buffers
* Add some missing unit tests
* Add tracking of heap usage for debugging purposes
* Fall back to non-device-local memory if device-local allocation fails

BUG=skia:5031
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356343003

Committed:
https://skia.googlesource.com/skia/+/c5850e9fdb62cc4ae5ed2b6af51aea92cac07455
==========

to

==========
Some Vulkan memory fixes and cleanup

* Switch back to not setting transfer_dst on all buffers
* Add some missing unit tests
* Add tracking of heap usage for debugging purposes
* Fall back to non-device-local memory if device-local allocation fails

BUG=skia:5031
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356343003

Committed:
https://skia.googlesource.com/skia/+/c5850e9fdb62cc4ae5ed2b6af51aea92cac07455
Committed:
https://skia.googlesource.com/skia/+/68c3d30702c8af5ae249c78b30a9ea2351f875ed
==========

[commit-bot: I haz the power, 2016-09-23 17:30:06]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/68c3d30702c8af5ae249c78b30a9ea2351f875ed