content/public/browser/browser_plugin_guest_delegate.h - Issue 235633002: <webview>: Move Geolocation permission to chrome layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/browser_plugin_guest_delegate.h

Issue 235633002: <webview>: Move Geolocation permission to chrome layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments and Merge with ToT Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/content_browser.gypi ('k') | content/public/browser/browser_plugin_guest_delegate.cc » ('j') | content/public/browser/browser_plugin_guest_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/browser_plugin_guest_delegate.h

diff --git a/content/public/browser/browser_plugin_guest_delegate.h b/content/public/browser/browser_plugin_guest_delegate.h

index 7e1c2f7c7a72094958850934adf6fcc8aee5aac2..89608f4a752293f06adad760f413ca7287bf9530 100644

--- a/content/public/browser/browser_plugin_guest_delegate.h

+++ b/content/public/browser/browser_plugin_guest_delegate.h

@@ -87,8 +87,8 @@ class CONTENT_EXPORT BrowserPluginGuestDelegate {

// Request permission from the delegate to perform an action of the provided

// |permission_type|. Details of the permission request are found in

// |request_info|. A |callback| is provided to make the decision.

- // Returns whether the delegate has, or will handle the permission request.

- virtual bool RequestPermission(

+ // Returns an unique identifier for the request.

jam 2014/04/14 18:11:55 this return value isn't used in content (which i a

Fady Samuel 2014/04/14 18:51:14 Done.

+ virtual int RequestPermission(

BrowserPluginPermissionType permission_type,

const base::DictionaryValue& request_info,

const PermissionResponseCallback& callback,