Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1984)

Unified Diff: content/public/browser/browser_plugin_guest_delegate.h

Issue 235633002: <webview>: Move Geolocation permission to chrome layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed tests in Debug mode Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/content_browser.gypi ('k') | content/public/browser/browser_plugin_guest_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/browser_plugin_guest_delegate.h
diff --git a/content/public/browser/browser_plugin_guest_delegate.h b/content/public/browser/browser_plugin_guest_delegate.h
index 7e1c2f7c7a72094958850934adf6fcc8aee5aac2..01deb0020b19cb480489971e655ac55ce9de9098 100644
--- a/content/public/browser/browser_plugin_guest_delegate.h
+++ b/content/public/browser/browser_plugin_guest_delegate.h
@@ -87,12 +87,11 @@ class CONTENT_EXPORT BrowserPluginGuestDelegate {
// Request permission from the delegate to perform an action of the provided
// |permission_type|. Details of the permission request are found in
// |request_info|. A |callback| is provided to make the decision.
- // Returns whether the delegate has, or will handle the permission request.
- virtual bool RequestPermission(
+ virtual void RequestPermission(
BrowserPluginPermissionType permission_type,
const base::DictionaryValue& request_info,
const PermissionResponseCallback& callback,
- bool allowed_by_default);
+ bool allowed_by_default) {}
// Requests resolution of a potentially relative URL.
virtual GURL ResolveURL(const std::string& src);
« no previous file with comments | « content/content_browser.gypi ('k') | content/public/browser/browser_plugin_guest_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698