content/browser/browser_plugin/test_browser_plugin_guest_delegate.cc - Issue 235633002: <webview>: Move Geolocation permission to chrome layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/test_browser_plugin_guest_delegate.cc

Issue 235633002: <webview>: Move Geolocation permission to chrome layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed tests in Debug mode Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/browser_plugin/test_browser_plugin_guest_delegate.h ('k') | content/browser/renderer_host/render_process_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/test_browser_plugin_guest_delegate.cc

diff --git a/content/browser/browser_plugin/test_browser_plugin_guest_delegate.cc b/content/browser/browser_plugin/test_browser_plugin_guest_delegate.cc

index 59ae63555d9799952204a15b277e0a1f2e896224..ec3c0d61c34bc749633f890ddc3b43e58ed2b500 100644

--- a/content/browser/browser_plugin/test_browser_plugin_guest_delegate.cc

+++ b/content/browser/browser_plugin/test_browser_plugin_guest_delegate.cc

@@ -50,15 +50,11 @@ void TestBrowserPluginGuestDelegate::RendererResponsive() {

void TestBrowserPluginGuestDelegate::RendererUnresponsive() {

}

-bool TestBrowserPluginGuestDelegate::RequestPermission(

+void TestBrowserPluginGuestDelegate::RequestPermission(

BrowserPluginPermissionType permission_type,

const base::DictionaryValue& request_info,

const PermissionResponseCallback& callback,

bool allowed_by_default) {

- return BrowserPluginGuestDelegate::RequestPermission(permission_type,

- request_info,

- callback,

- allowed_by_default);

}

void TestBrowserPluginGuestDelegate::SizeChanged(const gfx::Size& old_size,