Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2356323002: Revert of Mojo C++ bindings: always use MultiplexRouter with InterfacePtr/Binding. (Closed)

Created:
4 years, 3 months ago by yzshen1
Modified:
4 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mojo C++ bindings: always use MultiplexRouter with InterfacePtr/Binding. (patchset #3 id:40001 of https://codereview.chromium.org/2349293002/ ) Reason for revert: It probably caused browser_tests and unit_tests failures on https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/30483 Original issue's description: > Mojo C++ bindings: always use MultiplexRouter with InterfacePtr/Binding. > > This CL doesn't do the cleanup of removing Router and its usage, so that it is > pretty small and easy to revert if necessary. The cleanup will be in future CLs. > > BUG=594244 > > Committed: https://crrev.com/4f84285faf99679494e9fdb743ffc03f3959b1a3 > Cr-Commit-Position: refs/heads/master@{#420081} TBR=rockot@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=594244 Committed: https://crrev.com/ac99ca8b3fd4058dce64431dd407ab72ec5c7674 Cr-Commit-Position: refs/heads/master@{#420109}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
M mojo/public/cpp/bindings/binding.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/interface_ptr.h View 3 chunks +7 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/binding_state.h View 2 chunks +1 line, -5 lines 0 comments Download
M mojo/public/cpp/bindings/lib/binding_state.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_ptr_state.h View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yzshen1
Created Revert of Mojo C++ bindings: always use MultiplexRouter with InterfacePtr/Binding.
4 years, 3 months ago (2016-09-21 18:19:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356323002/1
4 years, 3 months ago (2016-09-21 18:20:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 18:21:53 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 18:24:00 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac99ca8b3fd4058dce64431dd407ab72ec5c7674
Cr-Commit-Position: refs/heads/master@{#420109}

Powered by Google App Engine
This is Rietveld 408576698