Issue 23563005: Add toSVGFontFaceUri|NameElement(), and use them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23563005: Add toSVGFontFaceUri|NameElement(), and use them. (Closed)

Created:
7 years, 3 months ago by gyuyoung-inactive

Modified:
7 years, 3 months ago

Reviewers:
tkent, (unused - use chromium)

CC:
blink-reviews, pdr, Stephen Chennney, f(malita)

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Add toSVGFontFaceUri|NameElement(), and use them. These functions have type checking assertions for helping to find bad-cast bugs. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157864

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -2 lines)			Patch
M	Source/core/svg/SVGFontFaceNameElement.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	Source/core/svg/SVGFontFaceSrcElement.cpp	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	Source/core/svg/SVGFontFaceUriElement.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/23563005/2001

7 years, 3 months ago (2013-09-16 22:10:24 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_blink_rel for step(s) webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, weborigin_unittests, wtf_unittests ...

7 years, 3 months ago (2013-09-16 22:25:09 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/23563005/2001

7 years, 3 months ago (2013-09-16 22:31:39 UTC) #5

Message was sent while issue was closed.

Change committed as 157864

Expand Messages | Collapse Messages