Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2356283002: Build tools on NoGPU bots. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
Brian Osman
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Build tools on NoGPU bots. I was just lazy disabling this before. It turns out to not be difficult. This gets us slightly better testing out of the NoGPU bot, as we now know not only that Skia compiles, but also that DM and nanobench can link (and thus that Skia's got enough compiled in it to be a coherent library). skpbench requires GPU support. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356283002 Committed: https://skia.googlesource.com/skia/+/38925aa37c17c0f54868852b8c3edf373400c742

Patch Set 1 #

Patch Set 2 : diff less #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -45 lines) Patch
M BUILD.gn View 1 3 chunks +50 lines, -45 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
mtklein_C
4 years, 3 months ago (2016-09-21 16:31:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356283002/20001
4 years, 3 months ago (2016-09-21 16:31:52 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-21 16:31:54 UTC) #8
Brian Osman
lgtm
4 years, 3 months ago (2016-09-21 16:42:06 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 17:11:27 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/38925aa37c17c0f54868852b8c3edf373400c742

Powered by Google App Engine
This is Rietveld 408576698