Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: tracing/tracing/metrics/system_health/cpu_time_metric.html

Issue 2356253005: Fix cpuTimeMetric (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/metrics/system_health/cpu_time_metric.html
diff --git a/tracing/tracing/metrics/system_health/cpu_time_metric.html b/tracing/tracing/metrics/system_health/cpu_time_metric.html
index b655f1e57ecac9cef672093e14864a98364af761..b28eb8d56991c37bc0e912f7b132ef248c76311f 100644
--- a/tracing/tracing/metrics/system_health/cpu_time_metric.html
+++ b/tracing/tracing/metrics/system_health/cpu_time_metric.html
@@ -36,6 +36,11 @@ tr.exportTo('tr.metrics.sh', function() {
!rangeOfInterest.intersectsExplicitRangeInclusive(
slice.start, slice.end))
return;
+ if ((typeof slice.cpuDuration !== 'number') ||
+ isNaN(slice.cpuDuration)) {
+ console.error(slice.cpuDuration, slice.title, slice.category);
+ return;
+ }
threadCpuTime += slice.cpuDuration;
});
processCpuTime += threadCpuTime;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698