Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2356253002: [wasm] Break a decoder loop if there is a failure. (Closed)

Created:
4 years, 3 months ago by ahaas
Modified:
4 years, 3 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Break a decoder loop if there is a failure. TEST=unittests/WasmModuleVerifyTest.Regression_648070 BUG=chromium:648070 R=titzer@chromium.org Committed: https://crrev.com/99b773c28ae764eaf53db675ac0e481a75c1a18a Cr-Commit-Position: refs/heads/master@{#39602}

Patch Set 1 #

Patch Set 2 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M src/wasm/module-decoder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
ahaas
4 years, 3 months ago (2016-09-21 15:34:25 UTC) #1
titzer
Can you go ahead and check if all the loops have such a check? lgtm
4 years, 3 months ago (2016-09-21 15:46:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356253002/20001
4 years, 3 months ago (2016-09-21 15:53:50 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-21 16:18:03 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 16:18:24 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/99b773c28ae764eaf53db675ac0e481a75c1a18a
Cr-Commit-Position: refs/heads/master@{#39602}

Powered by Google App Engine
This is Rietveld 408576698