components/password_manager/core/browser/stub_password_manager_client.cc - Issue 235623002: Password manager internals page: Improve security

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/stub_password_manager_client.cc

Issue 235623002: Password manager internals page: Improve security (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: innerHTML -> innerText Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/common/save_password_progress_logger.h ('K') | « components/password_manager/core/browser/stub_password_manager_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/stub_password_manager_client.cc

diff --git a/components/password_manager/core/browser/stub_password_manager_client.cc b/components/password_manager/core/browser/stub_password_manager_client.cc

index ff6ced88eb9a404121f9ccce0666b29add3c1948..96c4a5581e6af4fe6db800e1109995d7c944c960 100644

--- a/components/password_manager/core/browser/stub_password_manager_client.cc

+++ b/components/password_manager/core/browser/stub_password_manager_client.cc

@@ -24,8 +24,9 @@ PasswordManagerDriver* StubPasswordManagerClient::GetDriver() { return NULL; }

void StubPasswordManagerClient::SetLogger(PasswordManagerLogger* logger) {}

-void StubPasswordManagerClient::LogSavePasswordProgress(

- const std::string& text) {}

+void StubPasswordManagerClient::LogSavePasswordProgress(const std::vector<

+ autofill::SavePasswordProgressLogger::StructuredLog>& logs) {

bool StubPasswordManagerClient::IsLoggingActive() const { return false; }