Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc

Issue 235623002: Password manager internals page: Improve security (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: innerHTML -> innerText Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc
diff --git a/components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc b/components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc
index f46df5b48bdb6253021b6d6fb0661da16ad9c3e8..85e6ced5fcfa64a93501a9fdedaab41e45157b3d 100644
--- a/components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc
+++ b/components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc
@@ -12,8 +12,6 @@ namespace autofill {
namespace {
-const char kTestText[] = "test";
-
class TestLogger : public RendererSavePasswordProgressLogger {
public:
TestLogger() : RendererSavePasswordProgressLogger(&sink_, 0) {}
@@ -25,14 +23,15 @@ class TestLogger : public RendererSavePasswordProgressLogger {
// extracts the first |AutofillHostMsg_RecordSavePasswordProgress| message,
// fills the output parameter with the value of the message's parameter, and
// clears the queue of sent messages.
- bool GetLogMessage(std::string* log) {
+ bool GetLogMessage(
+ std::vector<SavePasswordProgressLogger::StructuredLog>* logs) {
const uint32 kMsgID = AutofillHostMsg_RecordSavePasswordProgress::ID;
const IPC::Message* message = sink_.GetFirstMessageMatching(kMsgID);
if (!message)
return false;
- Tuple1<std::string> param;
+ Tuple1<std::vector<SavePasswordProgressLogger::StructuredLog> > param;
AutofillHostMsg_RecordSavePasswordProgress::Read(message, &param);
- *log = param.a;
+ *logs = param.a;
sink_.ClearMessages();
return true;
}
@@ -45,10 +44,13 @@ class TestLogger : public RendererSavePasswordProgressLogger {
TEST(RendererSavePasswordProgressLoggerTest, SendLog) {
TestLogger logger;
- logger.SendLog(kTestText);
- std::string sent_log;
- EXPECT_TRUE(logger.GetLogMessage(&sent_log));
- EXPECT_EQ(kTestText, sent_log);
+ std::vector<SavePasswordProgressLogger::StructuredLog> logs;
+ logs.push_back(SavePasswordProgressLogger::StructuredLog(
+ SavePasswordProgressLogger::STRING_MESSAGE));
+ logger.SendLog(logs);
+ std::vector<SavePasswordProgressLogger::StructuredLog> sent_logs;
+ EXPECT_TRUE(logger.GetLogMessage(&sent_logs));
+ EXPECT_EQ(logs, sent_logs);
}
} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698