chrome/browser/resources/password_manager_internals/password_manager_internals.js - Issue 235623002: Password manager internals page: Improve security

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/password_manager_internals/password_manager_internals.js

Issue 235623002: Password manager internals page: Improve security (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client.cc ('k') | chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/password_manager_internals/password_manager_internals.js

diff --git a/chrome/browser/resources/password_manager_internals/password_manager_internals.js b/chrome/browser/resources/password_manager_internals/password_manager_internals.js

index 73aab6dde953deb86ee838ab4249b1c3f4a63bb2..4b7dd0abcd962d9d59099a7bc67b842a7441b3dc 100644

--- a/chrome/browser/resources/password_manager_internals/password_manager_internals.js

+++ b/chrome/browser/resources/password_manager_internals/password_manager_internals.js

@@ -2,12 +2,13 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+// |logText| is expected to be escaped for HTML.

function addSavePasswordProgressLog(logText) {

var logDiv = $('log-entries');

if (!logDiv)

return;

logDiv.appendChild(document.createElement('hr'));

var textDiv = document.createElement('div');

- textDiv.innerText = logText;

+ textDiv.innerHTML = logText;

Tom Sepez 2014/04/11 18:57:43 Oh, not so good. How can we avoid this?

vabr (Chromium) 2014/04/11 19:03:14 I can revert it to innerText without much troubles

logDiv.appendChild(textDiv);

}