chrome/browser/password_manager/chrome_password_manager_client.h - Issue 235623002: Password manager internals page: Improve security

Side by Side Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 235623002: Password manager internals page: Improve security (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: innerHTML -> innerText Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | components/autofill/core/common/save_password_progress_logger.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_	5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_

6 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_	6 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_

7	7

8 #include "base/basictypes.h"	8 #include "base/basictypes.h"

9 #include "base/compiler_specific.h"	9 #include "base/compiler_specific.h"

10 #include "components/password_manager/content/browser/content_password_manager_d river.h"	10 #include "components/password_manager/content/browser/content_password_manager_d river.h"

(...skipping 35 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
46 virtual void AuthenticateAutofillAndFillForm(	46 virtual void AuthenticateAutofillAndFillForm(

47 scoped_ptr<autofill::PasswordFormFillData> fill_data) OVERRIDE;	47 scoped_ptr<autofill::PasswordFormFillData> fill_data) OVERRIDE;

48 virtual PrefService* GetPrefs() OVERRIDE;	48 virtual PrefService* GetPrefs() OVERRIDE;

49 virtual password_manager::PasswordStore* GetPasswordStore() OVERRIDE;	49 virtual password_manager::PasswordStore* GetPasswordStore() OVERRIDE;

50 virtual password_manager::PasswordManagerDriver* GetDriver() OVERRIDE;	50 virtual password_manager::PasswordManagerDriver* GetDriver() OVERRIDE;

51 virtual base::FieldTrial::Probability GetProbabilityForExperiment(	51 virtual base::FieldTrial::Probability GetProbabilityForExperiment(

52 const std::string& experiment_name) OVERRIDE;	52 const std::string& experiment_name) OVERRIDE;

53 virtual bool IsPasswordSyncEnabled() OVERRIDE;	53 virtual bool IsPasswordSyncEnabled() OVERRIDE;

54 virtual void SetLogger(password_manager::PasswordManagerLogger* logger)	54 virtual void SetLogger(password_manager::PasswordManagerLogger* logger)

55 OVERRIDE;	55 OVERRIDE;

56 virtual void LogSavePasswordProgress(const std::string& text) OVERRIDE;	56 virtual void LogSavePasswordProgress(const std::vector<

	57 autofill::SavePasswordProgressLogger::StructuredLog>& logs) OVERRIDE;
	Ilya Sherman 2014/04/12 00:00:51 Wow, is this really how clang-format formats this Wow, is this really how clang-format formats this line? That's not great :/ vabr (Chromium) 2014/04/12 09:11:38 I can confirm this was clang-formated. Have you su Show quoted text On 2014/04/12 00:00:51, Ilya Sherman wrote: > Wow, is this really how clang-format formats this line? That's not great :/ I can confirm this was clang-formated. Have you suggestions for a better split? I actually don't see any, the type name got monstrously long. vabr (Chromium) 2014/04/16 20:55:36 Resolved: The type got shorter again. On 2014/04/1 Resolved: The type got shorter again. On 2014/04/12 09:11:38, vabr (Chromium) wrote: Show quoted text > On 2014/04/12 00:00:51, Ilya Sherman wrote: > > Wow, is this really how clang-format formats this line? That's not great :/ > > I can confirm this was clang-formated. > Have you suggestions for a better split? I actually don't see any, the type name > got monstrously long.
57 virtual bool IsLoggingActive() const OVERRIDE;	58 virtual bool IsLoggingActive() const OVERRIDE;

58	59

59 // Hides any visible generation UI.	60 // Hides any visible generation UI.

60 void HidePasswordGenerationPopup();	61 void HidePasswordGenerationPopup();

61	62

62 // Convenience method to allow //chrome code easy access to a PasswordManager	63 // Convenience method to allow //chrome code easy access to a PasswordManager

63 // from a WebContents instance.	64 // from a WebContents instance.

64 static password_manager::PasswordManager* GetManagerFromWebContents(	65 static password_manager::PasswordManager* GetManagerFromWebContents(

65 content::WebContents* contents);	66 content::WebContents* contents);

66	67

(...skipping 48 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
115	116

116 // Points to an active logger instance to use for, e.g., reporting progress on	117 // Points to an active logger instance to use for, e.g., reporting progress on

117 // saving passwords. If there is no active logger (most of the time), the	118 // saving passwords. If there is no active logger (most of the time), the

118 // pointer will be NULL.	119 // pointer will be NULL.

119 password_manager::PasswordManagerLogger* logger_;	120 password_manager::PasswordManagerLogger* logger_;

120	121

121 DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient);	122 DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient);

122 };	123 };

123	124

124 #endif // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_	125 #endif // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_

OLD	NEW