Password manager internals page: Improve security

chrome/browser/password_manager/chrome_password_manager_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/memory/singleton.h"
 #include "base/metrics/histogram.h"
@@ skipping 15 matching lines @@
 #include "components/password_manager/core/browser/password_manager_logger.h"
 #include "components/password_manager/core/browser/password_manager_metrics_util.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_view.h"
 #include "ipc/ipc_message_macros.h"
 
 #if defined(OS_ANDROID)
 #include "chrome/browser/android/password_authentication_manager.h"
 #endif  // OS_ANDROID
 
+using autofill::SavePasswordProgressLogger;
+
 namespace {
 
 bool IsTheHotNewBubbleUIEnabled() {
   std::string group_name =
       base::FieldTrialList::FindFullName("PasswordManagerUI");
 
   CommandLine* command_line = CommandLine::ForCurrentProcess();
   if (command_line->HasSwitch(switches::kDisableSavePasswordBubble))
     return false;
 
@@ skipping 130 matching lines @@
   // We should never be replacing one logger with a different one, because that
   // will leave the first without further updates, and the user likely confused.
   // TODO(vabr): For the reason above, before moving the internals page from
   // behind the flag, make sure to restrict the number of internals page
   // instances to 1 in normal profiles, and 0 in incognito.
   DCHECK(!logger || !logger_);
   logger_ = logger;
 }
 
 void ChromePasswordManagerClient::LogSavePasswordProgress(
-    const std::string& text) {
+    const std::vector<SavePasswordProgressLogger::StructuredLog>& logs) {
+  std::string text(SavePasswordProgressLogger::SanitizeStructuredLogs(logs));
   if (IsLoggingActive())
     logger_->LogSavePasswordProgress(text);
 }
 
 bool ChromePasswordManagerClient::IsLoggingActive() const {
   return logger_ != NULL;
 }
 
 // static
 password_manager::PasswordGenerationManager*
@@ skipping 86 matching lines @@
           web_contents(),
           web_contents()->GetView()->GetNativeView());
   popup_controller_->Show(false /* display_password */);
 #endif  // #if defined(USE_AURA)
 }
 
 void ChromePasswordManagerClient::CommitFillPasswordForm(
     autofill::PasswordFormFillData* data) {
   driver_.FillPasswordForm(*data);
 }