[Sensors] Adding chrome flag to enable Generic Sensor based APIs

[Sensors] Adding chrome flag to enable Generic Sensor based APIs

This change adds a flag to enable family of sensor APIs which are based on Generic Sensor API including Ambient Light Sensor API.
So far it is only available on Android and Mac OS, should become available on other platforms as soon as platform-specific implementation lands.

Generic Sensor API: https://w3c.github.io/sensors/
Ambient Light Sensor API: http://w3c.github.io/ambient-light/

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TkfdVqYAYiE

BUG=606766
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/d4096a0b4682c42131a40ba0f04e8263b1d19d13
Cr-Commit-Position: refs/heads/master@{#424703}

[Mikhail, 2016-09-21 12:37:04]

Description was changed from

==========
[Sensors] Adding chrome flag to enable Generic Sensor based APIs

This change adds a flag to enable family of sensor APIs which are based on
Generic Sensor API including Ambient Light Sensor API.
So far it is only available on Android, should become available on other
platforms as soon as platform-specific implementation lands.

Generic Sensor API: https://w3c.github.io/sensors/
Ambient Light Sensor API: http://w3c.github.io/ambient-light/

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TkfdVqYAYiE

BUG=606766
==========

to

==========
[Sensors] Adding chrome flag to enable Generic Sensor based APIs

This change adds a flag to enable family of sensor APIs which are based on
Generic Sensor API including Ambient Light Sensor API.
So far it is only available on Android, should become available on other
platforms as soon as platform-specific implementation lands.

Generic Sensor API: https://w3c.github.io/sensors/
Ambient Light Sensor API: http://w3c.github.io/ambient-light/

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TkfdVqYAYiE

BUG=606766
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Mikhail, 2016-09-21 12:40:15]

Patchset #1 (id:1) has been deleted

[Mikhail, 2016-09-21 12:40:34]

The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 12:40:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 12:43:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 12:43:01]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Mikhail, 2016-09-21 13:07:36]

The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 13:07:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mikhail, 2016-09-21 13:15:11]

Description was changed from

==========
[Sensors] Adding chrome flag to enable Generic Sensor based APIs

This change adds a flag to enable family of sensor APIs which are based on
Generic Sensor API including Ambient Light Sensor API.
So far it is only available on Android, should become available on other
platforms as soon as platform-specific implementation lands.

Generic Sensor API: https://w3c.github.io/sensors/
Ambient Light Sensor API: http://w3c.github.io/ambient-light/

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TkfdVqYAYiE

BUG=606766
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
[Sensors] Adding chrome flag to enable Generic Sensor based APIs

This change adds a flag to enable family of sensor APIs which are based on
Generic Sensor API including Ambient Light Sensor API.
So far it is only available on Android, should become available on other
platforms as soon as platform-specific implementation lands.

Generic Sensor API: https://w3c.github.io/sensors/
Ambient Light Sensor API: http://w3c.github.io/ambient-light/

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TkfdVqYAYiE

BUG=606766
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Mikhail, 2016-09-21 13:15:11]

mikhail.pozdnyakov@intel.com changed reviewers:
+ jochen@chromium.org

[Mikhail, 2016-09-21 13:39:34]

PTAL

[commit-bot: I haz the power, 2016-09-21 13:46:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 13:46:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mikhail, 2016-09-22 06:43:36]

The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 06:43:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 08:09:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 08:09:26]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-09-26 14:56:37]

I can't approve the histograms.xml change, I can only approve UseCounter
additions.

Can you explain why this needs an about:flags entry?

https://codereview.chromium.org/2356193002/diff/60001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2356193002/diff/60001/chrome/app/generated_re...
chrome/app/generated_resources.grd:15293: +    <message
name="IDS_FLAGS_ENABLE_GENERIC_SENSOR_NAME" desc="Title for the flag to enable
Generic Sensor.">
the message description should be verbose enough so somebody can translate this
without reading the entire CL for context

[Mikhail, 2016-09-26 15:15:15]

On 2016/09/26 14:56:37, jochen (slow) wrote:
> I can't approve the histograms.xml change, I can only approve UseCounter
> additions.
> 
> Can you explain why this needs an about:flags entry?
I just wanted to provide a way for web developers to try sensors APIs. Should I
have more rationales behind it?

[jochen (gone - plz use gerrit), 2016-09-27 18:59:39]

they can enable experimental web platform features in about:flags, that should
work, no?

[Mikhail, 2016-09-27 19:03:31]

On 2016/09/27 18:59:39, jochen (slow) wrote:
> they can enable experimental web platform features in about:flags, that should
> work, no?

Unfortunately it is not enough: we also need to enable mojo interface
initialization on browser side (pls look at
https://codereview.chromium.org/2356193002/diff/60001/content/browser/frame_h...).

[jochen (gone - plz use gerrit), 2016-09-29 11:59:24]

ok, in that case, you don't need to use content features, just regular switches
are enough

[Mikhail, 2016-09-29 17:58:32]

The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 17:58:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mikhail, 2016-09-29 18:02:37]

On 2016/09/29 11:59:24, jochen (slow) wrote:
> ok, in that case, you don't need to use content features, just regular
switches
> are enough

Done. Please take a look.

[commit-bot: I haz the power, 2016-09-29 18:41:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 18:41:56]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Mikhail, 2016-09-30 06:52:16]

The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 06:52:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 08:22:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 08:22:11]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-09-30 10:47:11]

lgtm

[Mikhail, 2016-09-30 11:25:57]

mikhail.pozdnyakov@intel.com changed reviewers:
+ asvitkine@chromium.org, gayane@chromium.org

[Mikhail, 2016-09-30 11:25:58]

Adding asvitkine@, gayane@ for histograms.xml changes.

https://codereview.chromium.org/2356193002/diff/60001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2356193002/diff/60001/chrome/app/generated_re...
chrome/app/generated_resources.grd:15293: +    <message
name="IDS_FLAGS_ENABLE_GENERIC_SENSOR_NAME" desc="Title for the flag to enable
Generic Sensor.">
On 2016/09/26 14:56:37, jochen (slow) wrote:
> the message description should be verbose enough so somebody can translate
this
> without reading the entire CL for context

Done.

[Alexei Svitkine (slow), 2016-09-30 14:51:35]

Have you considered using the base::Feature api instead? See
go/feature-api-announcement

It's the recommended way to add new enable/disable things to command line and
about flags.

[Mikhail, 2016-10-03 08:06:25]

On 2016/09/30 14:51:35, Alexei Svitkine (slow) wrote:
> Have you considered using the base::Feature api instead? See
> go/feature-api-announcement
> 
> It's the recommended way to add new enable/disable things to command line and
> about flags.

I tried it first (pls take look at patch set #3), but then changed it to a cmd
line switch as was requested by jochen@
(https://codereview.chromium.org/2356193002/#msg22)

[Alexei Svitkine (slow), 2016-10-03 14:57:35]

Jochen, can you elaborate why you advised against using base::Feature?

The new feature API is meant to replace --enable and --disable flags. This
is something that Chrome Eng Review explicitly emphasized during review of
that proposal - that the end state should be exclusively base::Features
used for such cases and not a mixture of two different things. (Now, it
will take some time to migrate all the older flags, but I'd rather we not
introduce any new ones.)

On Mon, Oct 3, 2016 at 4:06 AM, <mikhail.pozdnyakov@intel.com> wrote:

> On 2016/09/30 14:51:35, Alexei Svitkine (slow) wrote:
> > Have you considered using the base::Feature api instead? See
> > go/feature-api-announcement
> <https://goto.google.com/feature-api-announcement>
> >
> > It's the recommended way to add new enable/disable things to command
> line and
> > about flags.
>
> I tried it first (pls take look at patch set #3), but then changed it to a
> cmd
> line switch as was requested by jochen@
> (https://codereview.chromium.org/2356193002/#msg22)
>
> https://codereview.chromium.org/2356193002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Alexei Svitkine (slow), 2016-10-03 14:57:36]

Jochen, can you elaborate why you advised against using base::Feature?

The new feature API is meant to replace --enable and --disable flags. This
is something that Chrome Eng Review explicitly emphasized during review of
that proposal - that the end state should be exclusively base::Features
used for such cases and not a mixture of two different things. (Now, it
will take some time to migrate all the older flags, but I'd rather we not
introduce any new ones.)

On Mon, Oct 3, 2016 at 4:06 AM, <mikhail.pozdnyakov@intel.com> wrote:

> On 2016/09/30 14:51:35, Alexei Svitkine (slow) wrote:
> > Have you considered using the base::Feature api instead? See
> > go/feature-api-announcement
> <https://goto.google.com/feature-api-announcement>
> >
> > It's the recommended way to add new enable/disable things to command
> line and
> > about flags.
>
> I tried it first (pls take look at patch set #3), but then changed it to a
> cmd
> line switch as was requested by jochen@
> (https://codereview.chromium.org/2356193002/#msg22)
>
> https://codereview.chromium.org/2356193002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[jochen (gone - plz use gerrit), 2016-10-04 14:46:05]

On 2016/10/03 at 14:57:36, asvitkine wrote:
> Jochen, can you elaborate why you advised against using base::Feature?
> 
> The new feature API is meant to replace --enable and --disable flags. This
> is something that Chrome Eng Review explicitly emphasized during review of
> that proposal - that the end state should be exclusively base::Features
> used for such cases and not a mixture of two different things. (Now, it
> will take some time to migrate all the older flags, but I'd rather we not
> introduce any new ones.)

fair enough.

in this case, it's not adding a flag, however, so the diff was just smaller.

Note that runtime enabled features currently automatically create
--enable-$feature and --disable-$feature flags - maybe we should update the code
to automatically create base::Features instead / in addition?

[Alexei Svitkine (slow), 2016-10-04 19:42:59]

On 2016/10/04 14:46:05, jochen (slow) wrote:
> On 2016/10/03 at 14:57:36, asvitkine wrote:
> > Jochen, can you elaborate why you advised against using base::Feature?
> > 
> > The new feature API is meant to replace --enable and --disable flags. This
> > is something that Chrome Eng Review explicitly emphasized during review of
> > that proposal - that the end state should be exclusively base::Features
> > used for such cases and not a mixture of two different things. (Now, it
> > will take some time to migrate all the older flags, but I'd rather we not
> > introduce any new ones.)
> 
> fair enough.
> 
> in this case, it's not adding a flag, however, so the diff was just smaller.

Ah, I see - so because the flag existed already it was a smaller change to add
it to about flags? I still feel like we should just migrate this and this is a
good opportunity to do so - since the code is actually being touched in this CL.
(Else who knows when it will next be touched?)

> 
> Note that runtime enabled features currently automatically create
> --enable-$feature and --disable-$feature flags - maybe we should update the
code
> to automatically create base::Features instead / in addition?

It does sound like we should update that code. Can you file a crbug about that
with the details of how that currently works? Thanks!

[Mikhail, 2016-10-10 08:39:13]

The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 08:39:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 08:41:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 08:41:37]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Mikhail, 2016-10-10 10:54:55]

The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 10:55:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mikhail, 2016-10-10 12:09:28]

As far as I understand, the consensus for this CL is using base::Feature api. I
moved back to it in the latest patch. Please take a look.

[commit-bot: I haz the power, 2016-10-10 12:15:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 12:15:57]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-10-10 12:25:26]

lgtm

[Mikhail, 2016-10-11 09:27:05]

Alexei, do you have any comments on this CL? thanks

[Alexei Svitkine (slow), 2016-10-11 15:41:15]

lgtm

[Mikhail, 2016-10-12 07:49:33]

The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 07:50:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mikhail, 2016-10-12 07:52:26]

Description was changed from

==========
[Sensors] Adding chrome flag to enable Generic Sensor based APIs

This change adds a flag to enable family of sensor APIs which are based on
Generic Sensor API including Ambient Light Sensor API.
So far it is only available on Android, should become available on other
platforms as soon as platform-specific implementation lands.

Generic Sensor API: https://w3c.github.io/sensors/
Ambient Light Sensor API: http://w3c.github.io/ambient-light/

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TkfdVqYAYiE

BUG=606766
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
[Sensors] Adding chrome flag to enable Generic Sensor based APIs

This change adds a flag to enable family of sensor APIs which are based on
Generic Sensor API including Ambient Light Sensor API.
So far it is only available on Android and Mac OS, should become available on
other platforms as soon as platform-specific implementation lands.

Generic Sensor API: https://w3c.github.io/sensors/
Ambient Light Sensor API: http://w3c.github.io/ambient-light/

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TkfdVqYAYiE

BUG=606766
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-10-12 07:52:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 07:52:29]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Mikhail, 2016-10-12 08:36:00]

The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 08:36:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 08:46:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 08:46:55]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Mikhail, 2016-10-12 09:56:56]

The CQ bit was checked by mikhail.pozdnyakov@intel.com

[Mikhail, 2016-10-12 09:56:57]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2356193002/#ps180001
(title: "rebased")

[commit-bot: I haz the power, 2016-10-12 09:57:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 10:12:29]

Description was changed from

==========
[Sensors] Adding chrome flag to enable Generic Sensor based APIs

This change adds a flag to enable family of sensor APIs which are based on
Generic Sensor API including Ambient Light Sensor API.
So far it is only available on Android and Mac OS, should become available on
other platforms as soon as platform-specific implementation lands.

Generic Sensor API: https://w3c.github.io/sensors/
Ambient Light Sensor API: http://w3c.github.io/ambient-light/

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TkfdVqYAYiE

BUG=606766
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
[Sensors] Adding chrome flag to enable Generic Sensor based APIs

This change adds a flag to enable family of sensor APIs which are based on
Generic Sensor API including Ambient Light Sensor API.
So far it is only available on Android and Mac OS, should become available on
other platforms as soon as platform-specific implementation lands.

Generic Sensor API: https://w3c.github.io/sensors/
Ambient Light Sensor API: http://w3c.github.io/ambient-light/

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TkfdVqYAYiE

BUG=606766
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-10-12 10:12:31]

Committed patchset #9 (id:180001)

[commit-bot: I haz the power, 2016-10-12 10:15:20]

Description was changed from

==========
[Sensors] Adding chrome flag to enable Generic Sensor based APIs

This change adds a flag to enable family of sensor APIs which are based on
Generic Sensor API including Ambient Light Sensor API.
So far it is only available on Android and Mac OS, should become available on
other platforms as soon as platform-specific implementation lands.

Generic Sensor API: https://w3c.github.io/sensors/
Ambient Light Sensor API: http://w3c.github.io/ambient-light/

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TkfdVqYAYiE

BUG=606766
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
[Sensors] Adding chrome flag to enable Generic Sensor based APIs

This change adds a flag to enable family of sensor APIs which are based on
Generic Sensor API including Ambient Light Sensor API.
So far it is only available on Android and Mac OS, should become available on
other platforms as soon as platform-specific implementation lands.

Generic Sensor API: https://w3c.github.io/sensors/
Ambient Light Sensor API: http://w3c.github.io/ambient-light/

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TkfdVqYAYiE

BUG=606766
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/d4096a0b4682c42131a40ba0f04e8263b1d19d13
Cr-Commit-Position: refs/heads/master@{#424703}
==========

[commit-bot: I haz the power, 2016-10-12 10:15:22]

Patchset 9 (id:??) landed as
https://crrev.com/d4096a0b4682c42131a40ba0f04e8263b1d19d13
Cr-Commit-Position: refs/heads/master@{#424703}