third_party/WebKit/Source/modules/sensor/SensorReading.h - Issue 2356133002: Reland of [sensors] Ambient light sensor bindings implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/sensor/SensorReading.h

Issue 2356133002: Reland of [sensors] Ambient light sensor bindings implementation (Closed)

Patch Set: Rebased and fixed review comment from haraken. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/sensor/SensorReading.h

diff --git a/third_party/WebKit/Source/modules/sensor/SensorReading.h b/third_party/WebKit/Source/modules/sensor/SensorReading.h

index 2eaf7e6a177db48e75962b885ee31ae8b643de3d..9bc2a72f64adb85ef967a93cb62c46dfd93d4e15 100644

--- a/third_party/WebKit/Source/modules/sensor/SensorReading.h

+++ b/third_party/WebKit/Source/modules/sensor/SensorReading.h

@@ -16,7 +16,7 @@ class ExecutionContext;

class ScriptState;

class SensorReading

- : public GarbageCollected<SensorReading>

+ : public GarbageCollectedFinalized<SensorReading>

, public ScriptWrappable {

DEFINE_WRAPPERTYPEINFO();

public:

@@ -28,6 +28,8 @@ public:

// previous one; otherwise returns 'false'.

virtual bool isReadingUpdated(const SensorProxy::Reading& previous) const = 0;

+ virtual ~SensorReading();

protected:

explicit SensorReading(SensorProxy*);